Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8259574: SIGSEGV in BFSClosure::closure_impl #125

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/jfr/leakprofiler/chains/bfsClosure.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ void BFSClosure::do_oop(narrowOop* ref) {
}

void BFSClosure::do_root(UnifiedOopRef ref) {
assert(!ref.is_null(), "invariant");
assert(ref.dereference() != NULL, "pointee must not be null");
if (!_edge_queue->is_full()) {
_edge_queue->add(NULL, ref);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ template <typename Delegate>
void RootSetClosure<Delegate>::do_oop(narrowOop* ref) {
assert(ref != NULL, "invariant");
assert(is_aligned(ref, sizeof(narrowOop)), "invariant");
if (CompressedOops::is_null(*ref)) {
if (!CompressedOops::is_null(*ref)) {
_delegate->do_root(UnifiedOopRef::encode_in_native(ref));
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ class JavaThreadInVMAndNative : public StackObj {
};

static void post_events(bool exception_handler, Thread* thread) {
DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_vm(thread));
if (exception_handler) {
EventShutdown e;
e.set_reason("VM Error");
Expand Down