-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests #212
8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests #212
Conversation
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315937 merged as part of openjdk/jdk#15725. https://github.com/openjdk/jdk/commit/339034c150cad7d3e1df55dbfac6c2b7746c4f92.patch could be applied cleanly. Below are the results: * before_release: **117.84s user 10.43s system 685% cpu 18.725 total** * before_fastdebug: **375.61s user 13.10s system 838% cpu 46.382 total** * after_release: **119.35s user 11.63s system 728% cpu 17.991 total** * after_fastdebug: **381.47s user 13.07s system 857% cpu 46.003 total**
👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Improves test performance. Applies cleanly, test still passes. |
@roy-soumadipta The approval request has been created successfully. |
@roy-soumadipta This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@roy-soumadipta |
/sponsor |
Going to push as commit 66c77d9.
Your commit was automatically rebased without conflicts. |
@phohensee @roy-soumadipta Pushed as commit 66c77d9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315937 merged as part of openjdk/jdk#15725. https://github.com/openjdk/jdk/commit/eb1f67b160c4d2b8feb7330786ecd8e53ed53946.patch could be applied cleanly.
Below are the results:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/212/head:pull/212
$ git checkout pull/212
Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/jdk21u.git pull/212/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 212
View PR using the GUI difftool:
$ git pr show -t 212
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/212.diff
Webrev
Link to Webrev Comment