Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests #212

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Sep 28, 2023

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315937 merged as part of openjdk/jdk#15725. https://github.com/openjdk/jdk/commit/eb1f67b160c4d2b8feb7330786ecd8e53ed53946.patch could be applied cleanly.

Below are the results:

  • before_release: 117.84s user 10.43s system 685% cpu 18.725 total
  • before_fastdebug: 375.61s user 13.10s system 838% cpu 46.382 total
  • after_release: 119.35s user 11.63s system 728% cpu 17.991 total
  • after_fastdebug: 381.47s user 13.07s system 857% cpu 46.003 total

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315937 needs maintainer approval

Issue

  • JDK-8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/212/head:pull/212
$ git checkout pull/212

Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/jdk21u.git pull/212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 212

View PR using the GUI difftool:
$ git pr show -t 212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/212.diff

Webrev

Link to Webrev Comment

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315937 merged as part of openjdk/jdk#15725. https://github.com/openjdk/jdk/commit/339034c150cad7d3e1df55dbfac6c2b7746c4f92.patch could be applied cleanly.

Below are the results:
* before_release: **117.84s user 10.43s system 685% cpu 18.725 total**
* before_fastdebug: **375.61s user 13.10s system 838% cpu 46.382 total**
* after_release: **119.35s user 11.63s system 728% cpu 17.991 total**
* after_fastdebug: **381.47s user 13.07s system 857% cpu 46.003 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @roy-soumadipta could not find any commit with hash 339034c150cad7d3e1df55dbfac6c2b7746c4f92. Please update the title with the hash for an existing commit.

@roy-soumadipta roy-soumadipta changed the title Backport 339034c150cad7d3e1df55dbfac6c2b7746c4f92 Backport eb1f67b160c4d2b8feb7330786ecd8e53ed53946 Sep 28, 2023
@openjdk openjdk bot changed the title Backport eb1f67b160c4d2b8feb7330786ecd8e53ed53946 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

⚠️ @roy-soumadipta This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2023
@roy-soumadipta
Copy link
Contributor Author

/approval request Improves test performance. Applies cleanly, test still passes.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@roy-soumadipta The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@roy-soumadipta This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 6000176: 8314551: More generic way to handshake GC threads with monitor deflation
  • f455049: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 6a4e492: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
  • 915892d: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • c1f13ea: 8316514: Better diagnostic header for VtableStub
  • 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
  • 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • ... and 32 more: https://git.openjdk.org/jdk21u/compare/fc11f381e89feef2c5a6e6f22c21756508a7fdcd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2023
@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@roy-soumadipta
Your change (at version 9652c2b) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit 66c77d9.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 90f456c: 8315766: Parallelize gc/stress/TestStressIHOPMultiThread.java test
  • 834c45c: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • e76be61: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 6000176: 8314551: More generic way to handshake GC threads with monitor deflation
  • f455049: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 6a4e492: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
  • 915892d: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • c1f13ea: 8316514: Better diagnostic header for VtableStub
  • 69af26c: 8316859: RISC-V: Disable detection of V through HWCAP
  • 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • ... and 35 more: https://git.openjdk.org/jdk21u/compare/fc11f381e89feef2c5a6e6f22c21756508a7fdcd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@phohensee @roy-soumadipta Pushed as commit 66c77d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants