-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292579: (tz) Update Timezone Data to 2022c #19
Conversation
👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
I've opened #20 to bring in the tests as we have on 17u. This patch will need to be updated to include the test update. |
Can we get this one updated, as with 11u & 17u? Rampdown closes at the end of this week, at which point 8u is frozen for release. |
@alvdavi Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
I've updated this PR to account for the changes added in #20. I've ran the tests and they do pass. The rest of the PR is unchanged, an import of rearguard data from 2022c. Sorry about the force-push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me, clean backport bar the changes for rearguard and the additional copies of the tzdata files in 8u
Please label the bug with jdk8u-critical-request
and I'll approve.
@alvdavi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Approved for 8u |
/sponsor |
Going to push as commit 46da2c3. |
@gnu-andrew @alvdavi Pushed as commit 46da2c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…_linux_riscv64 Add_TARGET_OS_ARCH_linux_riscv64
Backport of tzdata 2022c to jdk8u using the rearguard data. This is the same change as openjdk/jdk8u-dev#119 but targeting jdk8u as suggested, aiming for this to be included as a critical fix for October release
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/19/head:pull/19
$ git checkout pull/19
Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk8u pull/19/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19
View PR using the GUI difftool:
$ git pr show -t 19
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/19.diff