New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8230231: font-family not updated in HTMLEditor #12
Conversation
👋 Welcome back shadzic! A progress list of the required criteria for merging this PR into |
@Maxoudela please edit the title as follows:
As for unit tests, you will very likely need to add this as a system test under
|
Webrevs
|
Thanks @kevinrushforth . I'm sorry for posting the Pull request like that, I will thoroughly read the contributing guidelines and updates my PR accordingly. I'll try to add a test asap, thanks for the pointer. |
No problem. I mainly wanted to make sure that you knew why the RFR wasn't sent. As for the note about the title matching, the contributing guidelines don't mention that and I now realize that they should -- I'll add that along with some other improvements I'll be making.
Great, thanks. |
Hum I do not succeed in running the existing test either. Here is my log. Apparently, the tests are failing because the WebView is null and not initialized. Do you have any clue of what I've been doing wrong? Should I try to update my gradle version and JDK version maybe?
|
The test failure is almost certainly due to not having the native WebKit libraries. Two options:
|
Allright, I've been able to build the WebKit. I am now trying to add my test. I took some snippets from MiscellaneousTest and add my method to HTMLEditorTest:
where fontFamilyComboBox is retrieved like that :
This idea is to add a Font family with a space in it, then apply it on the text. But I'm struggling to select a text portion, apply the font, then select elsewhere, and select back the text to demonstrate that the ComboBox is not updated. I tried to trigger some selectAll command but it's not working. If anyone has some ideas, I'm all ears. |
This bug still exists when the caret is placed on a text with the default font (""). |
Applying this patch creates a new bug: Selecting text with multiple fonts in HTMLEditor sets the text to a single font. Steps to reproduce: Expectation: "Hello world" is selected |
@Maxoudela are you interesting in pursuing this? |
I have indeed let this bug on the side. I would like to investigate but my time is limited these days. Especially that my patch is apparently creating another issue. I will try to give it another shot in the upcoming week. |
No hurry. I was just going through PRs that hadn't been updated in a while. |
The second issue regarding selecting texts with multiple fonts will be fixed when #155 is merged. |
Deeply sorry for the very long delay. I finally was able to dig on that subject again. I was able to write a test inspired by the other tests. Feel free to guide me to improve it in case it's a bit too complicate. Let me know if I should check for specific regressions somewhere. Thanks |
/reviewers 2 |
@kevinrushforth |
@jaybhaskar Can you also review this? |
Reviewers: @arapte @jaybhaskar |
@Maxoudela this pull request can not be integrated into git checkout JDK-8230231
git fetch https://git.openjdk.org/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Merge with main
@Maxoudela This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@Maxoudela This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Fix for javafxports/openjdk-jfx#573
Issue on JBS bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231
Fix: Check for quote when updating the font-family comboBox.
A new font is added as a resource for the test. This font is same as modules/javafx.web/src/main/native/Tools/DumpRenderTree/fonts/WebKitWeightWatcher100.ttf
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/12/head:pull/12
$ git checkout pull/12
Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jfx.git pull/12/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12
View PR using the GUI difftool:
$ git pr show -t 12
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/12.diff
Webrev
Link to Webrev Comment