Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265400: Update to gcc 10.3 on Linux #481

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 27, 2021

This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK 17 -- see JDK-8265373.

I ran a full build and test, including media and WebKit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/481/head:pull/481
$ git checkout pull/481

Update a local copy of the PR:
$ git checkout pull/481
$ git pull https://git.openjdk.java.net/jfx pull/481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 481

View PR using the GUI difftool:
$ git pr show -t 481

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/481.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 27, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

/reviewers 2

@openjdk
Copy link

openjdk bot commented Apr 27, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk
Copy link

openjdk bot commented Apr 29, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265400: Update to gcc 10.3 on Linux

Reviewed-by: arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ccf51e4: 8265206: Tree-/TableCell: editing state not updated on cell re-use
  • 0a68613: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop
  • cc70cdf: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 29, 2021
@johanvos
Copy link
Collaborator

works fine. Note: the entry says "gcc10.3.0-OL6.4+1.0" but I tested using the gcc10.3.0 on Ubuntu (18.04)

@kevinrushforth
Copy link
Member Author

the entry says "gcc10.3.0-OL6.4+1.0" but I tested using the gcc10.3.0 on Ubuntu (18.04)

Yeah, the "OL6.4" part is just the name of the devkit (generated for the JDK builds), since that was their baseline. You can see it in the JDK 17 sources here.

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Apr 29, 2021
@openjdk
Copy link

openjdk bot commented Apr 29, 2021

@kevinrushforth Since your change was applied there have been 3 commits pushed to the master branch:

  • ccf51e4: 8265206: Tree-/TableCell: editing state not updated on cell re-use
  • 0a68613: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop
  • cc70cdf: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

Your commit was automatically rebased without conflicts.

Pushed as commit e3e5116.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8265400-gcc-10.3 branch April 30, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants