-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265400: Update to gcc 10.3 on Linux #481
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
works fine. Note: the entry says "gcc10.3.0-OL6.4+1.0" but I tested using the gcc10.3.0 on Ubuntu (18.04) |
Yeah, the "OL6.4" part is just the name of the devkit (generated for the JDK builds), since that was their baseline. You can see it in the JDK 17 sources here. |
/integrate |
@kevinrushforth Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e3e5116. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK 17 -- see JDK-8265373.
I ran a full build and test, including media and WebKit.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/481/head:pull/481
$ git checkout pull/481
Update a local copy of the PR:
$ git checkout pull/481
$ git pull https://git.openjdk.java.net/jfx pull/481/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 481
View PR using the GUI difftool:
$ git pr show -t 481
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/481.diff