Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow C2 monitorexit to be a safepoint #208

Draft
wants to merge 4 commits into
base: fibers
Choose a base branch
from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Apr 11, 2024


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/loom.git pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.org/loom.git pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/loom/pull/208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2024

@dean-long This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@dean-long this pull request can not be integrated into fibers due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout fibers-monitorexit-safepoint
git fetch https://git.openjdk.org/loom.git fibers
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge fibers"
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant