Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Jira 4xx errors different from 5xx #261

Closed
wants to merge 1 commit into from
Closed

Treat Jira 4xx errors different from 5xx #261

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 21, 2019 •
edited by openjdk bot
Loading

Hi all,

Please review this small change that considers all 4xx errors returned from Jira as permanent (issue not found) errors, while 5xx errors may go away if the operation is retried.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 21, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2019

Webrevs

edvbld
edvbld approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot removed the rfr label Nov 21, 2019
@openjdk
Copy link

openjdk bot commented Nov 21, 2019

@rwestberg This change can now be integrated. The commit message will be:

Treat Jira 4xx errors different from 5xx

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 21, 2019
@rwestberg
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Nov 21, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 21, 2019
@openjdk
Copy link

openjdk bot commented Nov 21, 2019

@rwestberg
Pushed as commit 6bea8f3.

@mlbridge
Copy link

mlbridge bot commented Nov 21, 2019

Mailing list message from Robin Westberg on skara-dev:

Changeset: 6bea8f3
Author: Robin Westberg
Date: 2019-11-21 11:00:44 +0000
URL: https://git.openjdk.java.net/skara/commit/6bea8f31

Treat Jira 4xx errors different from 5xx

Reviewed-by: ehelin

! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvbld edvbld edvbld approved these changes

Assignees
No one assigned
Labels
integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwestberg @edvbld