Merge pull request #5595 from openjournals/joss.06531

Merging automatically
openjournals · Jul 9, 2024 · 2a4e981 · 2a4e981
2 parents fa78643 + 4bf64d5
commit 2a4e981
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 8 deletions.
diff --git a/joss.06531/10.21105.joss.06531.crossref.xml b/joss.06531/10.21105.joss.06531.crossref.xml
@@ -6,8 +6,8 @@
            version="5.3.1"
            xsi:schemaLocation="http://www.crossref.org/schema/5.3.1 http://www.crossref.org/schemas/crossref5.3.1.xsd">
   <head>
-    <doi_batch_id>20240531220818-c74dbe332ce7b89e74e955f1a1f57292dea7ab12</doi_batch_id>
-    <timestamp>20240531220818</timestamp>
+    <doi_batch_id>20240709171819-c74dbe332ce7b89e74e955f1a1f57292dea7ab12</doi_batch_id>
+    <timestamp>20240709171819</timestamp>
     <depositor>
       <depositor_name>JOSS Admin</depositor_name>
       <email_address>admin@theoj.org</email_address>
@@ -285,6 +285,21 @@ Software</journal_title>
 R., Robinson, M., &amp; Chapman, S. J. (2021). Python battery
 mathematical modelling (PyBaMM). Journal of Open Research Software,
 9(1). https://doi.org/10.5334/jors.309</unstructured_citation>
+          </citation>
+          <citation key="kirby2018efficient">
+            <article_title>Solver composition across the PDE/linear
+algebra barrier</article_title>
+            <author>Kirby</author>
+            <journal_title>SIAM Journal on Scientific
+Computing</journal_title>
+            <issue>1</issue>
+            <volume>40</volume>
+            <doi>10.1137/17M1133208</doi>
+            <cYear>2018</cYear>
+            <unstructured_citation>Kirby, R. C., &amp; Mitchell, L.
+(2018). Solver composition across the PDE/linear algebra barrier. SIAM
+Journal on Scientific Computing, 40(1), C76–C98.
+https://doi.org/10.1137/17M1133208</unstructured_citation>
           </citation>
           <citation key="Mitusch2019">
             <article_title>Dolfin-adjoint 2018.1: Automated adjoints for

diff --git a/joss.06531/10.21105.joss.06531.pdf b/joss.06531/10.21105.joss.06531.pdf
diff --git a/joss.06531/paper.jats/10.21105.joss.06531.jats b/joss.06531/paper.jats/10.21105.joss.06531.jats
@@ -238,10 +238,10 @@ a Creative Commons Attribution 4.0 International License (CC BY
   element method is required to use EchemFEM. Firedrake is preferred
   over FEniCS and FEniCSx for several reasons: it offers a custom
   preconditioning interface
-  (<xref alt="Mitusch et al., 2019" rid="ref-Mitusch2019" ref-type="bibr">Mitusch
-  et al., 2019</xref>), Firedrake continues to be actively developed
-  unlike FEniCS, and unlike FEniCSx, it already includes automatic
-  adjoint capabilities.</p>
+  (<xref alt="Kirby &amp; Mitchell, 2018" rid="ref-kirby2018efficient" ref-type="bibr">Kirby
+  &amp; Mitchell, 2018</xref>), Firedrake continues to be actively
+  developed unlike FEniCS, and unlike FEniCSx, it already includes
+  automatic adjoint capabilities.</p>
   <p>The repository includes several examples of electrochemical devices
   such as flow reactors, flow batteries, and CO2 electrolyzers.</p>
 </sec>
@@ -315,8 +315,8 @@ a Creative Commons Attribution 4.0 International License (CC BY
   available in Firedrake. A plethora of solver options are available
   through simple PETSc keywords and custom operators for preconditioning
   can be defined using Firedrake
-  (<xref alt="Mitusch et al., 2019" rid="ref-Mitusch2019" ref-type="bibr">Mitusch
-  et al., 2019</xref>). In Roy et al.
+  (<xref alt="Kirby &amp; Mitchell, 2018" rid="ref-kirby2018efficient" ref-type="bibr">Kirby
+  &amp; Mitchell, 2018</xref>). In Roy et al.
   (<xref alt="2023" rid="ref-roy2023scalable" ref-type="bibr">2023</xref>),
   scalable block preconditioners were developed for the electroneutral
   Nernst-Planck equations with DG and implemented in EchemFEM.</p>
@@ -357,6 +357,7 @@ a Creative Commons Attribution 4.0 International License (CC BY
 </body>
 <back>
 <ref-list>
+  <title></title>
   <ref id="ref-openfoamwebsite">
     <element-citation publication-type="webpage">
       <article-title>OpenFOAM</article-title>
@@ -618,6 +619,22 @@ a Creative Commons Attribution 4.0 International License (CC BY
       <pub-id pub-id-type="doi">10.5334/jors.309</pub-id>
     </element-citation>
   </ref>
+  <ref id="ref-kirby2018efficient">
+    <element-citation publication-type="article-journal">
+      <person-group person-group-type="author">
+        <name><surname>Kirby</surname><given-names>Robert C.</given-names></name>
+        <name><surname>Mitchell</surname><given-names>Lawrence</given-names></name>
+      </person-group>
+      <article-title>Solver composition across the PDE/linear algebra barrier</article-title>
+      <source>SIAM Journal on Scientific Computing</source>
+      <year iso-8601-date="2018">2018</year>
+      <volume>40</volume>
+      <issue>1</issue>
+      <pub-id pub-id-type="doi">10.1137/17M1133208</pub-id>
+      <fpage>C76</fpage>
+      <lpage>C98</lpage>
+    </element-citation>
+  </ref>
   <ref id="ref-Mitusch2019">
     <element-citation publication-type="article-journal">
       <person-group person-group-type="author">