-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: neurone_loader: A Python module for loading EEG data recorded with Bittium NeurOne #1626
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @rougier, @satra it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Sorry, I'm late because I'm on vacation but I will do it next week. |
@brainstorm - i have completed the checklist |
Thanks @satra! I noticed that you didn't check the versioning box... is it because it does not follow semver? (has a |
|
Thanks Satra, good points. @heilerich, could you please address the points raised please? |
I'm now reviewing the paper and software. I managed to install the software but I get trouble testing it because I can't get download the data (I opened an issue). Who is the second author (I cannot find any commit by him)? I also noticed the discrepancy between the GitHub release version (1.0.1) and the release given here (1.1.0). |
Problem solved. But tests are failing: 41 failed, 12 passed, 21 error in 3.13 seconds Example error:
test search in Also, it would be good to warn the user (in the README) that the test data is very large (> 2.75 Go). |
Thanks for your feedback everyone! Release Tag Statement of Need and Audience Testing Authors |
Tests are now working. I get 6 failed, 68 passed in 695.95 seconds. Difficult to say where it failed because the output is quite verbose. Last failed test was:
Apart from that I think the submission is now ok for me. |
Thanks for testing. I ran the tests again on my machines and everything passed. A CI Build of the most recent commit is also still passing. I suspect there is some kind of incompatibility regarding the environment. In any case, it seems you might have encountered an actual bug and I would really appreciate your help in resolving this. |
@satra Does it tick the remaining boxes for you according to #1626 (comment)? |
Looks all good to ship @arfon. |
@heilerich - At this point could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
I can then move forward with accepting the submission. |
@arfon I have seen your message! Thanks for the reminder. I'm really sorry for the delay, I'm terribly busy at the moment. I will try to fit this in tomorrow. |
Got it, thanks for the update! |
@arfon Okay, released, tagged, deployed, archived ;) |
@whedon set 10.5281/zenodo.3468534 as archive |
OK. 10.5281/zenodo.3468534 is the archive. |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1002 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1002, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@rougier, @satra - many thanks for your reviews here, and to @brainstorm for editing this one ✨ @heilerich - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @heilerich (Felix Heilmeyer)
Repository: https://github.com/heilerich/neurone_loader
Version: v1.1.0
Editor: @brainstorm
Reviewer: @rougier, @satra
Archive: 10.5281/zenodo.3468534
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@rougier & @satra, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @brainstorm know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @rougier
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @satra
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: