Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'donate' links and badges #627

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Add 'donate' links and badges #627

merged 2 commits into from
Nov 14, 2019

Conversation

xuanxu
Copy link
Member

@xuanxu xuanxu commented Nov 8, 2019

This PR adds "donate" links to the site's About page and to the repo's README page.

Re: #623

@danielskatz
Copy link
Collaborator

The title is a bit misleading - I think this is for JOSS's page, not NumFOCUS's. Otherwise, this looks reasonable, though it's a bit hard to see without actually being in context in the live (or a test) site.

@xuanxu xuanxu changed the title Add links and badges to Numfocus' donate page Add 'donate' links and badges Nov 8, 2019
@xuanxu
Copy link
Member Author

xuanxu commented Nov 8, 2019

Here's a screenshot, the PR just adds a link and a badge to the cost section:

Before:
before

After:
after

@danielskatz
Copy link
Collaborator

that looks good, thanks.

Could we also create a donate word, button, or link in the right side "TOC" in the about page?

@danielskatz
Copy link
Collaborator

@arfon - can you merge this one too, since I think it's much more likely that this is where potential donors will come, rather than to the github page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants