[#2] Configure ESLint using AirBnB style

.eslintignore

@@ -0,0 +1 @@
+lib/schemas/*

.eslintrc

@@ -0,0 +1,5 @@
+parser: babel-eslint
+extends: airbnb/base
+env:
+  node: true
+  browser: true

lib/index.js

@@ -1,5 +1,4 @@
 import 'babel-polyfill';
-import _ from 'underscore';
 import fs from 'fs';
 import path from 'path';
 import csv from 'csv';
@@ -8,17 +7,11 @@ import 'isomorphic-fetch';
 
 const DEFAULT_REGISTRY = Promise.promisify(csv.parse)(
   fs.readFileSync(path.join(__dirname, 'schemas', 'registry.csv'), 'utf8'),
-  {columns: true}
+  { columns: true }
 );
 
-let schemas = {
-  base: JSON.parse(fs.readFileSync(path.join(__dirname, 'schemas', 'data-package.json'), 'utf8')),
-  tabular: JSON.parse(fs.readFileSync(path.join(__dirname, 'schemas', 'tabular-data-package.json'), 'utf8')),
-  fiscal: JSON.parse(fs.readFileSync(path.join(__dirname, 'schemas', 'fiscal-data-package.json'), 'utf8')),
-}
-
 class Registry {
-  constructor(url=undefined) {
+  constructor(url = undefined) {
     if (!url) {
       this._registry = DEFAULT_REGISTRY;
     } else {
@@ -27,15 +20,15 @@ class Registry {
   }
 
   get() {
-    return this._get_registry();
+    return this._getRegistry();
   }
 
-  _get_registry() {
+  _getRegistry() {
     if (this._registry) return this._registry;
 
     this._registry = fetch(this._url)
                        .then((response) => {
-                         if (response.status != 200) {
+                         if (response.status !== 200) {
                            throw new Error('Bad response from server');
                          }
 
@@ -46,7 +39,7 @@ class Registry {
                            throw err;
                          }
 
-                         return Promise.promisify(csv.parse)(text, {columns: true});
+                         return Promise.promisify(csv.parse)(text, { columns: true });
                        });
 
     return this._registry;

package.json

@@ -18,6 +18,7 @@
   },
   "devDependencies": {
     "babel-cli": "^6.4.5",
+    "babel-eslint": "^5.0.0-beta8",
     "babel-istanbul": "^0.6.0",
     "babel-polyfill": "^6.3.14",
     "babel-preset-es2015": "^6.3.13",
@@ -27,6 +28,8 @@
     "browserify": "^13.0.0",
     "chai": "^3.0.0",
     "coveralls": "~2.11.4",
+    "eslint": "^1.10.3",
+    "eslint-config-airbnb": "^4.0.0",
     "fetch-mock": "^4.1.0",
     "karma": "^0.13.19",
     "karma-browserify": "^5.0.1",
@@ -39,9 +42,10 @@
     "watchify": "^3.7.0"
   },
   "scripts": {
-    "test": "npm run test:nodejs; npm run test:browser",
+    "test": "npm run lint; npm run test:nodejs; npm run test:browser",
     "test:browser": "karma start",
     "test:nodejs": "mocha --compilers js:babel-register --timeout 5000 ./test",
+    "lint": "eslint lib/**/*.js test/**/*.js",
     "coverage": "babel-node ./node_modules/.bin/babel-istanbul cover _mocha ./test/*",
     "coveralls": "cat ./coverage/lcov.info | coveralls"
   },

test/.eslintrc

@@ -0,0 +1,5 @@
+---
+env:
+  mocha: true
+rules:
+  no-unused-expressions: 0

test/test.js

@@ -1,7 +1,7 @@
 import fetchMock from 'fetch-mock';
 import Registry from '..';
 import chai from 'chai';
-chai.should()
+chai.should();
 
 describe('Data Package Registry', () => {
   const CONFIG = {
@@ -13,7 +13,7 @@ describe('Data Package Registry', () => {
       fetchMock.restore();
       fetchMock.mock(CONFIG.backend, 'id,title,schema,specification');
 
-      let registry = new Registry(CONFIG.backend);
+      const registry = new Registry(CONFIG.backend);
 
       registry.get().then.should.be.not.undefined;
     });
@@ -24,7 +24,7 @@ describe('Data Package Registry', () => {
       fetchMock.restore();
       fetchMock.mock(CONFIG.backend, 'id,title,schema,specification\n1,2,3,4');
 
-      let registry = new Registry(CONFIG.backend);
+      const registry = new Registry(CONFIG.backend);
 
       registry.get().then((data) => {
         data.should.be.not.empty;
@@ -38,7 +38,7 @@ describe('Data Package Registry', () => {
       fetchMock.restore();
       fetchMock.mock(CONFIG.backend, 'id,title,schema,specification');
 
-      let registry = new Registry(CONFIG.backend);
+      const registry = new Registry(CONFIG.backend);
 
       registry.get().then((data) => {
         data.should.be.empty;
@@ -52,9 +52,9 @@ describe('Data Package Registry', () => {
       fetchMock.restore();
       fetchMock.mock(CONFIG.backend, 500);
 
-      let registry = new Registry(CONFIG.backend);
+      const registry = new Registry(CONFIG.backend);
 
-      registry.get().catch((error) => {
+      registry.get().catch(() => {
         done();
       });
     });
@@ -65,15 +65,15 @@ describe('Data Package Registry', () => {
       fetchMock.restore();
       fetchMock.mock(CONFIG.backend, 'id,title,schema,specification\n1,2,3,4');
 
-      let registry = new Registry(CONFIG.backend);
+      const registry = new Registry(CONFIG.backend);
 
       registry.get().then(() => {
         fetchMock.restore();
         fetchMock.mock(CONFIG.backend, 500);
 
-        registry.get().then((data) => {
+        registry.get().then(() => {
           done();
-        })
+        });
       });
     });
   });