Add product search functionality #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span class="input-group-btn"> | ||
| <button class="btn btn-default" type="button"><i class="fa fa-search"></i></button> | ||
| <button onclick="javascript:document.getElementById('search_form').submit()" class="btn btn-default" type="button"><i class="fa fa-search"></i></button> |
There was a problem hiding this comment.
I dont think we need onclick js to submit the form. Just changing the type of button to submit should do ?
|
@sharoonthomas there is any reason to not merge this PR? |
|
@pokoli it cannot be merged automatically because of merge conflicts. you could send a fresh PR which merged automatically or I have to manually merge it. Just being lazy of course ;) |
Conflicts: templates/webshop/base.jinja
|
Just merged lastest changes manually and pushed it. |
|
Merged manually as a single commit: 88d0812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.