Add a writeStyles option to KML format #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1827,6 +1828,14 @@ olx.format.KMLOptions.prototype.defaultStyle; | |||
|
|
|||
|
|
|||
| /** | |||
| * Write styles into KML. Default is `true`. | |||
| * @type {boolean|undefined} | |||
| * @api stable | |||
There was a problem hiding this comment.
stable because extractStylesis already stable?
There was a problem hiding this comment.
Yes, but I am happy to make this option experimental at this stage.
|
LGTM |
|
Typo in the PR description: |
|
Description updated. Thanks @gberaudo. |
elemoine
pushed a commit
that referenced
this pull request
Nov 6, 2015
Add a writeStyles option to KML format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
writeStylesboolean option tool.format.KML. If this option is set tofalsethe format does not add styles to the generated KML document. This option complements theextractStyleswe already have for read.