Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paypal "Suspected Fraud" Fix #147

Closed
sreichel opened this issue Dec 22, 2016 · 4 comments
Closed

Paypal "Suspected Fraud" Fix #147

sreichel opened this issue Dec 22, 2016 · 4 comments

Comments

@sreichel
Copy link
Contributor

Hello,

since upgrading our shop to Mag. 1.9 we have some problems with paypal orders caused by rounding problems.

Found a working solution at https://www.kreativundsoehne.de/blog/magento-rundungsfehler-in-version-1-9-x.html

Would you includes this here to keep it update-safe? If "yes" i could also add an admin option to turn this on/off if desired.

@tomekjordan
Copy link

tomekjordan commented Mar 12, 2017

Yep in 1931 there is still bug with paypal rounding related to
/app/code/core/Mage/Paypal/Model/Api/Nvp.php

I hope somebody could fix it finally, because above solution is old and not working
Thanks

@sreichel
Copy link
Contributor Author

@tomekjordan the above solution is definitly working for Paypal Standard. but you're right .... there is still a bug in Nvp.php (Paypal Express).

I'll try ...

@trabulium
Copy link
Contributor

trabulium commented Apr 24, 2017

I have this ugly / questionable fix for this running in production on a few stores. I say questionable because we 'force' an adjustment if we find that there's a small difference and ugly because the code was mostly done as emergency hotfixes during sale periods (when the issue would generally appear). From an accounting perspective, it's not ideal because it's not fixing the core of the issue, rather masking the underlying issue. Still, it's much better than constantly getting checkout issues. I doubt you will want a PR for it.. but let me know if you do.

trabulium@816e8be

@sreichel
Copy link
Contributor Author

sreichel commented Jan 31, 2018

@salubrium If you can create a PR ... I'd like to test it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants