Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N98-magerun tests fails since #2993 #4034

Closed
F1Red5 opened this issue Jun 8, 2024 · 2 comments
Closed

N98-magerun tests fails since #2993 #4034

F1Red5 opened this issue Jun 8, 2024 · 2 comments
Labels

Comments

@F1Red5
Copy link
Contributor

F1Red5 commented Jun 8, 2024

Currently working on N98-magerun with latest releases.

Since #2993 (v20.1.0) some unit tests fail.

Before this PR tests run w/o errors/failures.

@davidhiendl can you please re-check your code?

Additional note:

  • php7.4 ... 11 failures
  • php8.x ... 4 errors, 7 failures
@F1Red5 F1Red5 added the bug label Jun 8, 2024
@davidhiendl
Copy link
Contributor

@fballiano Sorry for not getting around to it sooner. Is this resolved? From the PR #4036 it looks like getDefaultAttributes was blacklisted from tests for some reason hence why it was not caught before. What is weird to me is how that method can be missing in those circumstances and that it requires a (in my opinion) somewhat not nice is-defined check.

@fballiano
Copy link
Contributor

I merged the related PR. since we can't control the development of magerun unless we have specific issues I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants