Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iterating over functions in opcheckot.js #42

Closed
tmotyl opened this issue Oct 2, 2015 · 1 comment
Closed

iterating over functions in opcheckot.js #42

tmotyl opened this issue Oct 2, 2015 · 1 comment
Labels
bug JavaScript Relates to js/*

Comments

@tmotyl
Copy link
Contributor

tmotyl commented Oct 2, 2015

in opcheckout.js https://github.com/OpenMage/magento-lts/blob/1.9.2.1/skin/frontend/base/default/js/opcheckout.js#L93 the for loop iterates over all object properties, including functions.
If one of the properties is undefined, the script will break, and it will NOT be possible to proceed with checkout.

This happend to us once livechat vendor has error in their js (hosted by them) which added an undefined property to dom objects. And it broke the chekout.

How it should be solved:
we should not loop over all object properties, but only over DOM nodes.
tmotyl added a commit to macopedia/magento-lts that referenced this issue Oct 11, 2015
@tmotyl
opcheckout.js should iterate over elements, not functions
d05ef15 
This patch make use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
@tmotyl tmotyl mentioned this issue Oct 11, 2015
Merged
@tmotyl
Copy link
Contributor Author

tmotyl commented Oct 28, 2015

thanks!

Flyingmana pushed a commit to Flyingmana/magento-lts that referenced this issue Oct 18, 2016
@tmotyl @Flyingmana
opcheckout.js should iterate over elements, not functions
66a659e 
This patch make use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
@tomekjordan tomekjordan mentioned this issue Feb 22, 2017
Closed
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Nov 27, 2017
@tmotyl @edannenberg
[bug#47] opcheckout.js should iterate over elements, not functions
fe3bc79 
This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Dec 6, 2017
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
fed9ad7 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 28, 2018
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
701f14e 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Jul 17, 2018
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
273fdc1 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Sep 19, 2018
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
42d691d 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 14, 2019
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
d4321b8 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Apr 1, 2019
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
2933ebe 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 22, 2019
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
db40f8f 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Oct 25, 2019
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
a54f153 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 20, 2020
@tmotyl @edannenberg
[bug-OpenMage#47] opcheckout.js should iterate over elements, not fun…
d7762bb 
…ctions

This patch makes use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage#42
randallelliott714 added a commit to randallelliott714/magento that referenced this issue Oct 18, 2022
@randallelliott714
opcheckout.js should iterate over elements, not functions
812e430 
This patch make use of the prototype's ``each`` function
to iterate over dom elements instead of all object properties and functions.

fixes OpenMage/magento-lts#42
@matteotestoni matteotestoni mentioned this issue Mar 16, 2023
Closed
@andyt andyt mentioned this issue Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug JavaScript Relates to js/*
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmotyl @sreichel