Prefered leader #18
Merged
Prefered leader #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
May 23, 2019
| if (!memberState.isLeader()) { | ||
| return; | ||
| } | ||
| String pid = dLedgerConfig.getPreferredLeaderId(); |
There was a problem hiding this comment.
It would be better to change pid to peerId
| @@ -226,6 +231,10 @@ public void changeRoleToFollower(long term, String leaderId) { | |||
| return CompletableFuture.completedFuture(new VoteResponse(request).term(memberState.getLedgerEndTerm()).voteResult(VoteResponse.RESULT.REJECT_TERM_SMALL_THAN_LEDGER)); | |||
| } | |||
|
|
|||
| if (!self && isTakingLeadership() && request.getLedgerEndIndex() == memberState.getLedgerEndIndex()) { | |||
There was a problem hiding this comment.
For the sake of insurance, compare LedgerEndTerm first.
| return; | ||
| } | ||
| } else { | ||
| return; |
There was a problem hiding this comment.
Role may be follower when term < memberState.getTermToTakeLeadership() , it should not return directly, setting TAKE_LEADERSHIP_FAILED is more appropriate. For example, the node receive heartbeat before term increase as a candidate, it will be follower and term will not increase.
|
@Jason918 I will merge this PR to branch prefered_leader at first, then make it easier to be polished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferred Leader implementation.
Also add the leadership transfer command in BossCommand. Using the following command, we can transfer leadership from n0 to n1 on term 1.
java -jar target/DLedger.jar leadershipTransfer -p "n0-localhost:20911;n1-localhost:20912;n2-localhost:20913" -l n0 -t n1 --term 1