correct codomain map join for security filter #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does look to fix the initial error but there appear to be further problems with shares in 5.3.0. |
mtbc
force-pushed
the
codomain-filter-join
branch
from
8056603
to
6affdce
Compare
This was referenced Apr 13, 2017
Merged
|
testing with #5250 |
|
reverse intensity is supported in share |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adjust the security filter for reading codomain map context instances in shares.
Testing this PR
@pwalczysko has the relevant share workflows.
Related reading
#4793
https://trello.com/c/sMxu4Rwi/73-codomain-map-context-in-shares-and-public-user