Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic groups code change suggestion (Modular Arithmetic - Foundations of computation) #418

Open
Sukanya-rs opened this issue Apr 25, 2022 · 0 comments
Open

Cyclic groups code change suggestion (Modular Arithmetic - Foundations of computation) #418

Sukanya-rs opened this issue Apr 25, 2022 · 0 comments
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@Sukanya-rs
Copy link

Description

Suggestion to change the print statement that is part of "Cyclic groups" of "Modular Arithmetic"(Course: Foundations of computation).

Change print(f"{g}^{count}={prev_power}")

to #print(f"{prev_power}mod{m}, {prev_power}")

Are you interested in working on this improvement yourself?

  • Yes, I can once it is confirmed that it is fine to change.

Explanation for the changes suggested:

Screenshot 2022-04-25 at 1 39 46 PM

Screenshot 2022-04-25 at 1 40 57 PM
@Sukanya-rs Sukanya-rs added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sukanya-rs