Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bazel support #106

Closed
bcebere opened this issue Jul 19, 2020 · 1 comment · Fixed by #116
Closed

Add Bazel support #106

bcebere opened this issue Jul 19, 2020 · 1 comment · Fixed by #116
Assignees
Labels
Build Related to the build of the package Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Type: New Feature ➕ Introduction of a completely new addition to the codebase

Comments

@bcebere
Copy link
Member

bcebere commented Jul 19, 2020

Feature Description

Bazel support would have numerous advantages in TenSEAL's build system.

Pros

  • We would be extending the cmake build system, not replacing it.
  • Well-established ML tools like PyTorch or Tensorflow support Bazel too, and it would make the integration seamless there.
  • The integration with SEAL would be easy, no submodule required, as in this example. Bazel has bindings to other build systems as well https://github.com/OpenMined/PIR/blob/master/third_party/seal.BUILD
  • It would be a major improvement for integration/deployment in Bazel system, it would install all the depends without any hassle, just the TenSEAL reference in their bazel file, as in this example https://github.com/OpenMined/PIR
  • It supports multiple languages, like C++/Python/Go/Rust and so on.
  • It supports pytest/gtest, no need for installing/running extra tools. Just bazel test and it executes all the tests in the repository, no matter the language/framework.

Cons

@bcebere bcebere added Type: New Feature ➕ Introduction of a completely new addition to the codebase Build Related to the build of the package Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues labels Jul 19, 2020
@bcebere bcebere mentioned this issue Jul 26, 2020
9 tasks
@bcebere bcebere self-assigned this Jul 27, 2020
@bcebere
Copy link
Member Author

bcebere commented Jul 27, 2020

I'll work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to the build of the package Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant