Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non GMS data layer #11

Merged
merged 1 commit into from
May 15, 2023
Merged

Non GMS data layer #11

merged 1 commit into from
May 15, 2023

Conversation

HectorNarvaez
Copy link
Contributor

Added implementation for data layer on non GMS module

This PR is related to #7, in order to split it into multiple smaller PR's

This PR depends on #10 and can see easy diff clicking here.

Only merge this once #10 is merged.

@HectorNarvaez HectorNarvaez added Don't merge Can't be merged yet Depends on This have dependency with another PR labels May 15, 2023
@HectorNarvaez HectorNarvaez removed Don't merge Can't be merged yet Depends on This have dependency with another PR labels May 15, 2023
Anwera64
Anwera64 suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that some of the files here that are marked as new were also added in #7. Could you check?

...-drive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/OmhStorageClientImpl.kt Show resolved Hide resolved
...ive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleRetrofitImpl.kt Show resolved Hide resolved
...rive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleStorageREST.kt Show resolved Hide resolved
Anwera64
Anwera64 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@Anwera64 Anwera64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HectorNarvaez
Copy link
Contributor Author

@Anwera64 there are many files added on #7 and here but as this will be merged first, once #7 be rebased the duplicated files will dissapear

@HectorNarvaez HectorNarvaez merged commit 5d38e72 into main May 15, 2023
2 checks passed
@HectorNarvaez HectorNarvaez deleted the state/nonGmsDataLayer branch May 15, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anwera64 Anwera64 Anwera64 approved these changes

@wilsoncastiblanco wilsoncastiblanco Awaiting requested review from wilsoncastiblanco

@jdiegoh3 jdiegoh3 Awaiting requested review from jdiegoh3

@hans-hamel hans-hamel Awaiting requested review from hans-hamel

@bardur-encora bardur-encora Awaiting requested review from bardur-encora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HectorNarvaez @Anwera64