Define abstractions #10
Conversation
HectorNarvaez
added
Don't merge
HectorNarvaez
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64,
hans-hamel and
bardur-encora
| interface OmhStorageClient { | ||
|
|
||
| interface Builder { | ||
| fun build(context: Context): OmhStorageClient |
There was a problem hiding this comment.
You should also request the OmhAuthClient. Let me know when you're available to help you setup that dependency.
| fun build(context: Context): OmhStorageClient | ||
| } | ||
|
|
||
| fun setupAccessToken(token: String) |
There was a problem hiding this comment.
You should depend on the OMH Auth library to handle the access token and it's refreshing
| import android.content.Context | ||
| import kotlin.reflect.KClass | ||
|
|
||
| object OmhStorageProvider { |
There was a problem hiding this comment.
Add a TODO comment to indicate that this needs to be refactored in the future once there's more code done for GMS and non GMS
| return outputList | ||
| } | ||
| for (gDriveFileOrFolder in inputList) { | ||
| outputList.add( |
There was a problem hiding this comment.
could you extract the content of the for loop into a separate function to reduce indentation?
| @@ -1 +1,14 @@ | |||
| package com.omh.android.storage.api.data.model | |||
|
|
|||
| interface RemoteFileOrFolder | |||
There was a problem hiding this comment.
Would we benefit of using a sealed class here instead?
| import com.omh.android.storage.api.domain.model.FileOrFolder | ||
| import com.omh.android.storage.api.domain.model.Folder | ||
|
|
||
| fun fromFilesFoldersRemoteListToDomain(inputList: List<RemoteFileOrFolder>): List<FileOrFolder> { |
There was a problem hiding this comment.
This should be feasible using a .map() function and passing the mapping function.
| @@ -1 +1,17 @@ | |||
| package com.omh.android.storage.api.domain.model | |||
|
|
|||
| interface FileOrFolder { | |||
There was a problem hiding this comment.
Same here with the sealed class
| val modificationDate: Long | ||
| } | ||
|
|
||
| data class File( |
There was a problem hiding this comment.
Are you using the additional functions of the data class implementation? If not, I'd suggest removing the anotation
| interface GetAllFilesAndFolders { | ||
| fun execute() | ||
| fun execute(): List<FileOrFolder> |
There was a problem hiding this comment.
You should return an OmhTask object. You can copy the implementation from the auth lib.
HectorNarvaez
removed
Don't merge
HectorNarvaez
force-pushed
the
state/defineAbstractions
branch
from
9b9482d
to
29627a2
Compare
Define the abstractions that will be exposed to the users
This PR is related to #7, in order to split it into multiple smaller PR's
This PR depends on #9 and can see easy diff clicking here.
Only merge this once #9 is merged.