Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in __init__ fails loading plugin #15

Open
khenderick opened this issue Aug 17, 2017 · 0 comments
Open

Exceptions in __init__ fails loading plugin #15

khenderick opened this issue Aug 17, 2017 · 0 comments

Comments

@khenderick
Copy link
Contributor

No exceptions should occur during init of a plugin. If one is raised, the plugin fails to load and won't be running/used.

Code that might fail (e.g. API calls) should be separated in a different thread that can re-try every X time. This will at least cause the plugin to start (but might be disabled), and be auto-enable once the code succeeds. Even if it's a unrecoverable issue, catching the error and logging it will allow the user to actually see the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant