GCI-9 Check bad Codepractices

[itatriev]

1. Loggers should be private static finale and sharing name convention
2. Avoid commented-out lines of code
   Task's Ticket
   Melange-Task

[harsha89]

Looks Good!

[k-joseph]

This Pull request says it is from unknown repository, hence making it not so easy to pull from it! any idea how i can do this devs?

[djazayeri]

I have never seen "unknown repository" before...

[k-joseph]

I think it is because@itatriev happened to delete his own fork for core after creating this PR

[itatriev]

@k-joseph Yeah, I did, because I had some problems with git and though "it would be more easy if I will REfork repo again". I wanted to refork it

[k-joseph]

Thanks @itatriev for your reply, we are merging gci work into openmrs-core soon and we need you to fork and open up a new Pull request that can allow me to pull from it to resolve conflicts if you would love us to have your work merged,

Regards

[k-joseph]

Any way, i have added these commits by my self since we are out of time 👍

[itatriev]

I'm sorry, I was not at home, should I do this right now or it's to late?

On Tue, Feb 24, 2015, 9:31 PM k-joseph notifications@github.com wrote:

Any way, i have added these commits by my self since we are out of time [image:
👍]

—
Reply to this email directly or view it on GitHub
#1219 (comment).

[k-joseph]

Closing this PR since it is included in: #1356