Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-4839: Exposing Patient Search Options Via #1872

Closed
wants to merge 4 commits into from
Closed

TRUNK-4839: Exposing Patient Search Options Via #1872

wants to merge 4 commits into from

Conversation

Nishen-Peiris
Copy link

Description

01.Remove unused import org.hibernate.HibernateException
02.Remove 1 redundant type arguments in the new expression at org.openmrs.api.db.hibernate.HibernatePatientDAO#sortDuplicatePatients
03.Remove 2 redundant type arguments in new expressions at org.openmrs.api.db.hibernate.HibernatePatientDAO#getPatients(String, boolean, Integer, Integer)
04.Remove 7 redundant type arguments in the new expression at org.openmrs.api.db.hibernate.HibernatePatientDAO#getDuplicatePatientsSQLString

Related Issue

I haven't implemented the feature completely.
see https://issues.openmrs.org/browse/TRUNK-4839

Checklist:

  • My pull request only contains one single commit.
  • My pull request is based on the latest master branch
    git pull --rebase upstream master.
  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Nishen Peiris added 4 commits November 16, 2016 17:40
…pi.db.hibernate.HibernatePatientDAO#getPatients(String, boolean, Integer, Integer)
…s.api.db.hibernate.HibernatePatientDAO#sortDuplicatePatients
…s.api.db.hibernate.HibernatePatientDAO#getDuplicatePatientsSQLString
@mention-bot
Copy link

@Nishen-Peiris, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karrtikiyer-tw, @lluismf and @bmamlin to be potential reviewers.

@dkayiwa
Copy link
Member

dkayiwa commented Nov 16, 2016

@Nishen-Peiris thanks again for working on this. :)
Do you mind squashing the commits into one?
Hopefully you had a look at this: https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 55.709% when pulling 9092e73 on Nishen-Peiris:TRUNK-4839 into e037b58 on openmrs:master.

@Nishen-Peiris
Copy link
Author

@dkayiwa OK.

@Nishen-Peiris
Copy link
Author

I'm closing this pull request. This is the link to the new pull request. #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants