TRUNK-4839: Exposing Patient Search Options Via UI #1873
Conversation
…mrs.api.db.hibernate.HibernatePatientDAO
| @@ -192,7 +191,7 @@ private void insertPatientStubIfNeeded(Patient patient) { | |||
| criteriaExactMatch = new PatientSearchCriteria(sessionFactory, criteriaExactMatch).prepareCriteria(query, true, | |||
| true, includeVoided); | |||
|
|
|||
| Set<Patient> patients = new LinkedHashSet<Patient>(); | |||
| Set<Patient> patients = new LinkedHashSet<>(); | |||
There was a problem hiding this comment.
Do you mind sharing the reason behind removing Patient?
The same question applies to the rest of the code below.
There was a problem hiding this comment.
@dkayiwa, Its a new feature introduced by Java 7 know as the "Diamond" operator. For more info, follow http://openjdk.java.net/projects/jdk7/features/#f618
There was a problem hiding this comment.
@Nishen-Peiris oh i see! :)
The ticket under which you are creating these pull requests does not seem related to the changes you are making. Do you mind creating a new ticket? :)
|
@Nishen-Peiris thanks again for all that you are doing! 👍 |
|
@dkayiwa thanks... |
Description
01.Remove unused import org.hibernate.HibernateException
02.Remove 1 redundant type arguments in the new expression at org.openmrs.api.db.hibernate.HibernatePatientDAO#sortDuplicatePatients
03.Remove 2 redundant type arguments in new expressions at org.openmrs.api.db.hibernate.HibernatePatientDAO#getPatients(String, boolean, Integer, Integer)
04.Remove 7 redundant type arguments in the new expression at org.openmrs.api.db.hibernate.HibernatePatientDAO#getDuplicatePatientsSQLString
Related Issue
I haven't implemented the feature completely.
see https://issues.openmrs.org/browse/TRUNK-4839
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.