[GCI-142] Delete unnecessary interface methods identifiers #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In principle, i fully agree with you on this. 😊 |
|
@dkayiwa Here is link for the discussion: https://talk.openmrs.org/t/openmrs-core-delete-unnecessary-interface-methods-identifiers/14514 |
|
This has merge conflicts. But then, am still a bit reluctant to merge this because of the trade off between the real value it adds and touching so many files leading to back porting merge conflicts. |
|
@BartlomiejRasztabiga let me hope you are fine with closing this for now. We can always reopen it after reaching a consensus on the talk thread that you started. Feel free to share objections, if any. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.openmrs.org/browse/GCI-142
Related PR: #2366
I've deleted redundant interface method indentifiers e.g. "public", "static". Because all Java interfaces methods are by default public and static. I don't know if it's right with your coding conventions so forgive me :)