-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCI-142: Removed APIException #2781
Conversation
Why are you removing the API Exception? |
Sonar pointed it out saying as it is a runtime exception it'll never run |
You need to give details of that. Or at least a link explaining so. For it is not correct to say that an APIException will never run. |
Should I write it in the PR itself? |
Whatever you can do to empower the reviewer with knowledge as to why you are raising this pull request. 😊 |
@dkayiwa alright 😊 |
I added the Sonar Issues in the PR itself. I hope this is sufficient 😃 |
Thanks @Bisht13 👍 |
Description of what I changed
One of my changes from my PR #2780
Removing APIException
Sonar errors:-
https://goo.gl/3386fk
https://goo.gl/kLi4JP
https://goo.gl/KFE81t
https://goo.gl/1UVjLa
https://goo.gl/rR5MEx
https://goo.gl/27NHJX
https://goo.gl/vv1gza
https://goo.gl/g3AWcX
https://goo.gl/ZKkQ9U
Issue I worked on
see https://issues.openmrs.org/browse/GCI-142
Task Instance https://codein.withgoogle.com/dashboard/task-instances/6187644498214912/
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
My IDE is configured to follow the [code style]
I have added tests to cover my changes.
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.