TRUNK-5816 Enable failings tests on Windows #3380
Conversation
teleivo
force-pushed
the
TRUNK-5816-failing-tests-on-windows
branch
from
5568d08
to
13c0efb
Compare
to see the run using a GitHub action
I am pretty sure that is not it but wanted to double check OpenmrsUtil.copyFile does not close the InputStream the InputStream should in our test only point to the mp3 in our resources and not the temp dir
teleivo
force-pushed
the
TRUNK-5816-failing-tests-on-windows
branch
from
13c0efb
to
9ec81a4
Compare
to show that the writing to the file and reading back is actually working. I believe this assertion should be in the test irrespective of our current issues
the content of the second obs data is empty because we reused the same input stream to write to it. It was already consumed.
I mean I am not so sure about the API in general but closing the stream will not allow anyone from reading the obs data Its just to figure out where the line is that is holding on Also I did close them in the test in the finally
ibacher
force-pushed
the
master
branch
2 times, most recently
from
e8f7850
to
1877e06
Compare
|
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) |
|
tl;dr closing this PR since it has not seen any activity in the last 6 months. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner. Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :) |
to see the run using a GitHub action
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5816
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master