Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUNK-5816 Enable failings tests on Windows #3380

Closed
wants to merge 7 commits into from
Closed

TRUNK-5816 Enable failings tests on Windows #3380

wants to merge 7 commits into from

Commits on Jul 18, 2020

  1. TRUNK-5816 Enable failings tests on Windows 

    to see the run using a GitHub action
    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    9d4ec23 View commit details
    Browse the repository at this point in the history

  2. TRUNK-5816 Add spotbugs to help find open handle

    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    40196d9 View commit details
    Browse the repository at this point in the history

  3. TRUNK-5816 InputStream is never closed in Handler 

    I am pretty sure that is not it but wanted to double check
OpenmrsUtil.copyFile does not close the InputStream
the InputStream should in our test only point to the mp3 in our
resources and not the temp dir
    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    9ec81a4 View commit details
    Browse the repository at this point in the history

  4. TRUNK-5816 Assert that what we write is actually in the obs 

    to show that the writing to the file and reading back is actually
working. I believe this assertion should be in the test irrespective of
our current issues
    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    1299e33 View commit details
    Browse the repository at this point in the history

  5. TRUNK-5816 Use another InputStream so data is written 

    the content of the second obs data is empty because we reused the same
input stream to write to it. It was already consumed.
    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    8ea1561 View commit details
    Browse the repository at this point in the history

  6. TRUNK-5816 Ensure In/OutputStream are closed after write

    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    222e20b View commit details
    Browse the repository at this point in the history

  7. TRUNK-5816 Desperation: of course not the fix 

    I mean I am not so sure about the API in general but closing the stream
will not allow anyone from reading the obs data

Its just to figure out where the line is that is holding on
Also I did close them in the test in the finally
    @teleivo
    teleivo committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    a4c7c89 View commit details
    Browse the repository at this point in the history