RAD-307 View report templates from list #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivange94, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Schwasrz94 to be a potential reviewer |
| "Error occured while dispaying template => " + exception.getMessage()); | ||
| return new ModelAndView("/module/radiology/radiologyDashboardForm"); | ||
| } | ||
| catch (IllegalArgumentException exception) { |
There was a problem hiding this comment.
@ivange94 I dont think we should catch that.
you need to make sure that this
mrrtReportTemplate = mrrtReportTemplateService.getMrrtReportTemplateByUuid(templateId);
so add this before the try block
mrrtReportTemplate = mrrtReportTemplateService.getMrrtReportTemplateByUuid(templateId);
if (mrrtReportTemplate == null) {
throw new IllegalArgumentException("MrrtReportTemplate not found. templateId '" + templateId + "' unknown.");
}otherwise you mask the actual problem.
There was a problem hiding this comment.
@ivange94 of course we need an ATshould and test for that; but you can then just rewrite the test you already wrote for IllegalArgumentException :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAD-307 View report templates from list
Description
Related Issue
see https://issues.openmrs.org/browse/RAD-307
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.