RESTWS-676: Improve resource definition properties #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 13, 2020
| @@ -98,7 +100,11 @@ public Model getCREATEModel(Representation rep) { | |||
| @Override | |||
| public Model getUPDATEModel(Representation representation) { | |||
| return new ModelImpl() | |||
| .property("name", new StringProperty()); //FIXME missing props | |||
|
|
|||
There was a problem hiding this comment.
I think the extra spaces should be removed on lines 103-104.
ghost
reviewed
Jan 13, 2020
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
|
|
|
Also, I was wondering if the rep could be null and how would super.getCREATEmodel(rep) handle it. Overall, I think the code looks clean. |
|
@gitcliff can you improve the spelling of the title please thanks, |
sherrif10
reviewed
Apr 20, 2020
| @@ -101,7 +103,7 @@ public Model getGETModel(Representation rep) { | |||
| .property("name", new StringProperty()) | |||
| .property("description", new StringProperty()) | |||
| .property("voided", new StringProperty()) | |||
| .property("memberIds", new ArrayProperty(new IntegerProperty())); //FIXME | |||
| .property("memberIds", new ArrayProperty(new IntegerProperty())); | |||
There was a problem hiding this comment.
Here the code seems to look alike
ibacher
force-pushed
the
master
branch
2 times, most recently
from
f9c73bb
to
2a4407f
Compare
corneliouzbett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK:https://issues.openmrs.org/browse/RESTWS-676
Improve Resource Definition Properties