-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTWS-676: Improve resource definition properties #405
base: master
Are you sure you want to change the base?
Conversation
@@ -98,7 +100,11 @@ public Model getCREATEModel(Representation rep) { | |||
@Override | |||
public Model getUPDATEModel(Representation representation) { | |||
return new ModelImpl() | |||
.property("name", new StringProperty()); //FIXME missing props | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the extra spaces should be removed on lines 103-104.
import java.util.ArrayList; | ||
import java.util.Collection; | ||
import java.util.List; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this space
Also, I was wondering if the rep could be null and how would super.getCREATEmodel(rep) handle it. Overall, I think the code looks clean. |
@gitcliff can you improve the spelling of the title please thanks, |
@@ -101,7 +103,7 @@ public Model getGETModel(Representation rep) { | |||
.property("name", new StringProperty()) | |||
.property("description", new StringProperty()) | |||
.property("voided", new StringProperty()) | |||
.property("memberIds", new ArrayProperty(new IntegerProperty())); //FIXME | |||
.property("memberIds", new ArrayProperty(new IntegerProperty())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the code seems to look alike
f9c73bb
to
2a4407f
Compare
LINK:https://issues.openmrs.org/browse/RESTWS-676
Improve Resource Definition Properties