-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCLOMRS-35: As a user I should be able to search and see all sources #26
Conversation
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
@@ -26,3 +26,4 @@ yarn.lock | |||
|
|||
#test snapshots | |||
**/__snapshots__/** | |||
src/components/dashboard/container/ListContainer.jsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new line at the end of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const store = mockStore({ payload: {} }); | ||
|
||
return store.dispatch(fetchSources('ciel', ['Dictionary'], 10, 1, 'sortAsc=name')).then(() => { | ||
// return of async actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the above comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really.
It has been deleted.
OCLOMRS-40: redesign sources page user interface (openmrs#27)
…n"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
…better code" (openmrs#22)" (openmrs#23) This reverts commit 5fcea0d. Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24) * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
…ode" (openmrs#22) * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. * Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" This reverts commit a0444d4. * Revert "OCLOMRS-29:Restructure app to improve code maintainability (openmrs#19)" This reverts commit e77aa4d. * Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code (openmrs#17)" This reverts commit 7e68e2f. Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23) This reverts commit 5fcea0d. Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24) * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
…n"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27) OCLOMRS-36: paginate search results (openmrs#28)
…s to fail (#608) * Bindu | OCLOMRS-848 | MOBN-1407 | persist notification data into localstorage (#26) * Bindu | OCLOMRS-848 | MOBN-1407 | persist notification data into localstorage * Bindu | OCLOMRS-848 | MOBN-1407 | Adding test cases for localStorageUtil * Bindu | OCLOMRS-848 | MOBN-1407 | Addressed the feedback changes * Bindu | OCLOMRS-848 | MOBN-1407 | Adding check for empty results array * Bindu | OCLOMRS-848 | MOBN-1407 | fixing the failing integration test
JIRA TICKET NAME:
As a user I should be able to search and see all sources
Summary:
Implement the UI and logic for retrieving all sources in OCL, search for a specific source, filter by source types and sort by ascending or descending order of names.