OCLOMRS-35: As a user I should be able to search and see all sources #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
| @@ -26,3 +26,4 @@ yarn.lock | |||
|
|
|||
| #test snapshots | |||
| **/__snapshots__/** | |||
| src/components/dashboard/container/ListContainer.jsx | |||
There was a problem hiding this comment.
Could you add the new line at the end of the file
shakirandagire
approved these changes
Jun 1, 2018
dkayiwa
reviewed
Jun 2, 2018
| const store = mockStore({ payload: {} }); | ||
|
|
||
| return store.dispatch(fetchSources('ciel', ['Dictionary'], 10, 1, 'sortAsc=name')).then(() => { | ||
| // return of async actions |
There was a problem hiding this comment.
Not really.
It has been deleted.
hadijahkyampeire
pushed a commit
to hadijahkyampeire/openmrs-ocl-client
that referenced
this pull request
Jun 12, 2018
OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire
pushed a commit
to hadijahkyampeire/openmrs-ocl-client
that referenced
this pull request
Jun 12, 2018
…n"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire
pushed a commit
to hadijahkyampeire/openmrs-ocl-client
that referenced
this pull request
Jun 12, 2018
…better code" (openmrs#22)" (openmrs#23) This reverts commit 5fcea0d. Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24) * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire
pushed a commit
to hadijahkyampeire/openmrs-ocl-client
that referenced
this pull request
Jun 12, 2018
…ode" (openmrs#22) * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. * Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" This reverts commit a0444d4. * Revert "OCLOMRS-29:Restructure app to improve code maintainability (openmrs#19)" This reverts commit e77aa4d. * Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code (openmrs#17)" This reverts commit 7e68e2f. Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23) This reverts commit 5fcea0d. Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24) * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire
pushed a commit
to hadijahkyampeire/openmrs-ocl-client
that referenced
this pull request
Jun 14, 2018
…n"" (openmrs#25) * Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)" This reverts commit 20ecf9b. * Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)" This reverts commit f2f81b0. * Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" This reverts commit 5fcea0d. * Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)" This reverts commit f6d6d28. * Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)" This reverts commit f6be69c. OCLOMRS-35: display sources and enable searching (openmrs#26) OCLOMRS-40: redesign sources page user interface (openmrs#27) OCLOMRS-36: paginate search results (openmrs#28)
kirity-mahanty
pushed a commit
that referenced
this pull request
Aug 20, 2020
…s to fail (#608) * Bindu | OCLOMRS-848 | MOBN-1407 | persist notification data into localstorage (#26) * Bindu | OCLOMRS-848 | MOBN-1407 | persist notification data into localstorage * Bindu | OCLOMRS-848 | MOBN-1407 | Adding test cases for localStorageUtil * Bindu | OCLOMRS-848 | MOBN-1407 | Addressed the feedback changes * Bindu | OCLOMRS-848 | MOBN-1407 | Adding check for empty results array * Bindu | OCLOMRS-848 | MOBN-1407 | fixing the failing integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TICKET NAME:
As a user I should be able to search and see all sources
Summary:
Implement the UI and logic for retrieving all sources in OCL, search for a specific source, filter by source types and sort by ascending or descending order of names.