tests should fail for additionalProperties in nested objects

[ScatteredInk]

At the moment, this entityStatement will fail if used in a test:

 {
    "extraField": "hello",
    "publicationDetails": {
      "publicationDate": "2019-06-13",
      "publisher": {
        "name": "Example Register"
      },
      "bodsVersion": "0.2"
    },
    "statementID": "60bb3996-b434-4377-930b-39972c65b400",
    "statementType": "entityStatement",
    "statementDate": "2019-05-05",
    "entityType": "registeredEntity",
    "name": "Listed Company OS-17"
}

But this entityStatement will pass:

 {
    "publicationDetails": {
      "extraField": "hello",
      "publicationDate": "2019-06-13",
      "publisher": {
        "name": "Example Register"
      },
      "bodsVersion": "0.2"
    },
    "statementID": "60bb3996-b434-4377-930b-39972c65b400",
    "statementType": "entityStatement",
    "statementDate": "2019-05-05",
    "entityType": "registeredEntity",
    "name": "Listed Company OS-17"
}

This line is adding additionalProperties false only at the root of the object, whereas we want it everywhere.

data-standard/tests/bods_validate.py

Line 69 in 3c113b2

schema['additionalProperties'] = False

This file was built before we had compile-to-jsonschema so maybe worth switching to that here?

[kd-ods]

Yes - just saw this: OpenDataServices/compile-to-json-schema#4

[ScatteredInk]

Fixed with #251