Garbage collection clarifications #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #338
| @@ -799,6 +803,10 @@ | |||
| An <code><a>RTCIceTransport</a></code> instance is constructed (optionally) from an <code><a>RTCIceGatherer</a></code>. | |||
| If <var>gatherer.state</var> is "closed" or <var>gatherer.component</var> is "RTCP", then throw an <code>InvalidStateError</code> exception. | |||
| </p> | |||
| <p> | |||
| An <code><a>RTCIceTransport</a></code> object in the "closed" state can be garbage-collected | |||
| when it is no longer referenced. | |||
There was a problem hiding this comment.
This should be "closed" or "failed".
There was a problem hiding this comment.
Currently, the non-normative ICE state diagram in Section 3.6 shows a potential transition from "failed" to "checking" or "disconnected".
|
FYI - I disagree on the "failed". It might be possible recover with ice restart or with continuous gathering in the future. In my ortc implementation it is possible to recover. |
robin-raymond
pushed a commit
that referenced
this pull request
Mar 1, 2016
Garbage collection clarifications - merging but we don't indicate in ORTC which ORTC object holds a reference to other ORTC objects to keep ORTC objects from being GC'ed so further clarification will be needed.
|
Sorry, my mistake. Regarding "recover with ice restart or with continuous gathering" I also hope that another use-case is considered: network temporary disconnection without involving private/public IP change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #338