Split armor at empty line

[toberndo]

The empty line that separates armor header from body can contain whitespace-y characters. See #193

Currently we split at: /^\s*\n/m;

Suggestions:

/^\s_?\n/m;
/^[\t ]\n/m;
/^[\t ]$/;
/^\s_$/;

[Robert-Nelson]

/^\s*?\n/m; has the same effect as the existing code so it won't work. The other three that I gave should all work.

----- Original Message -----

| From: "Thomas Oberndörfer" notifications@github.com
| To: "openpgpjs/openpgpjs" openpgpjs@noreply.github.com
| Sent: Wednesday, April 9, 2014 9:58:33 AM
| Subject: [openpgpjs] Split armor at empty line (#209)

| The empty line that separates armor header from body can contain whitespace-y
| characters. See #193

| Currently we split at: /^\s*\n/m;

| Suggestions:

| /^\s_?\n/m;
| /^[\t ] \n/m;
| /^[\t ] $/;
| /^\s_$/;

| —
| Reply to this email directly or view it on GitHub .

[toberndo]

I checked:

"\f\r\t\v​\u00a0\u1680​\u180e\u2000​\u2001\u2002​\u2003\u2004​\u2005\u2006​\u2007\u2008\u2009\u200a​\u2028\u2029​​\u202f\u205f​\u3000".replace(/ /g,'')

And it doesn't replace other whitespace characters.

So I think /^[\t ]\n/m; would only filer out spaces (0x20) and tabs but not other whitespace characters.

[toberndo]

@Robert-Nelson how about /^[^\S\n]*\n/m; from http://stackoverflow.com/questions/3469080/how-do-i-match-whitespace-but-not-newlines ?

[Robert-Nelson]

I think that would work but is overly complex with the multiple negatives.

I think the simplest is:

/^[ \t]*\n/m

I remember now why I used the "m" modifier, I wanted the trailing \n included in the match, so some of my other suggestions earlier weren't right.

----- Original Message -----

| From: "Thomas Oberndörfer" notifications@github.com
| To: "openpgpjs/openpgpjs" openpgpjs@noreply.github.com
| Cc: "Robert Nelson" robertn@the-nelsons.org
| Sent: Wednesday, April 9, 2014 11:09:57 AM
| Subject: Re: [openpgpjs] Split armor at empty line (#209)

| @Robert-Nelson how about /^[^\S\n]*\n/m; from
| http://stackoverflow.com/questions/3469080/how-do-i-match-whitespace-but-not-newlines
| ?

| —
| Reply to this email directly or view it on GitHub .

[Robert-Nelson]

Ah, forgot about damn unicode, in that case go with your suggestion.

----- Original Message -----

| From: "Thomas Oberndörfer" notifications@github.com
| To: "openpgpjs/openpgpjs" openpgpjs@noreply.github.com
| Cc: "Robert Nelson" robertn@the-nelsons.org
| Sent: Wednesday, April 9, 2014 10:24:42 AM
| Subject: Re: [openpgpjs] Split armor at empty line (#209)

| I checked:
| "\f\r\t\v​\u00a0\u1680​\u180e\u2000​\u2001\u2002​\u2003\u2004​\u2005\u2006​\u2007\u2008\u2009\u200a​\u2028\u2029​​\u202f\u205f​\u3000".replace(/
| /g,'')

| And it doesn't replace other whitespace characters.

| So I think /^[\t ]\n/m; would only filer out spaces (0x20) and tabs but not
| other whitespace characters.

| —
| Reply to this email directly or view it on GitHub .

[Robert-Nelson]

Btw RFC 4880 says empty line so I'm not sure that technically any whitespace chars are valid. :-)

----- Original Message -----

| From: "Robert B. Nelson" robertn@the-nelsons.org
| To: "openpgpjs/openpgpjs"
| reply@reply.github.com
| Cc: "openpgpjs/openpgpjs" openpgpjs@noreply.github.com
| Sent: Wednesday, April 9, 2014 12:47:46 PM
| Subject: Re: [openpgpjs] Split armor at empty line (#209)

| Ah, forgot about damn unicode, in that case go with your suggestion.

| ----- Original Message -----

| | From: "Thomas Oberndörfer" notifications@github.com
|
| | To: "openpgpjs/openpgpjs" openpgpjs@noreply.github.com
|
| | Cc: "Robert Nelson" robertn@the-nelsons.org
|
| | Sent: Wednesday, April 9, 2014 10:24:42 AM
|
| | Subject: Re: [openpgpjs] Split armor at empty line (#209)
|

| | I checked:
|
| | "\f\r\t\v​\u00a0\u1680​\u180e\u2000​\u2001\u2002​\u2003\u2004​\u2005\u2006​\u2007\u2008\u2009\u200a​\u2028\u2029​​\u202f\u205f​\u3000".replace(/
| | /g,'')
|

| | And it doesn't replace other whitespace characters.
|

| | So I think /^[\t ]\n/m; would only filer out spaces (0x20) and tabs but not
| | other whitespace characters.
|

| | —
|
| | Reply to this email directly or view it on GitHub .
|

[toberndo]

Created pull request for this issue: #225