Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output from tidy-IncrementsRelativeParts is sub-optimal #788

Open
Puzzled-Face opened this issue Feb 6, 2024 · 1 comment
Open

Output from tidy-IncrementsRelativeParts is sub-optimal #788

Puzzled-Face opened this issue Feb 6, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority

Comments

@Puzzled-Face
Copy link
Collaborator

.DefaultIncrementsRelativeParts() %>% tidy()
An object of class "IncrementsRelativeParts"
Slot "dlt_start":
[1] 0

Slot "clean_start":
[1] 1

Slot "intervals":
[1] 0 2

Slot "increments":
[1] 2 1

> .DefaultIncrementsRelativeParts() %>% tidy()
$dlt_start
# A tibble: 1 × 1
  dlt_start
      <int>
1         0

$clean_start
# A tibble: 1 × 1
  clean_start
        <int>
1           1

$intervals
# A tibble: 2 × 1
  intervals
      <dbl>
1         0
2         2

$increments
# A tibble: 2 × 1
  increments
       <dbl>
1          2
2          1

attr(,"class")
[1] "tbl_IncrementsRelativeParts" "list"      

The intervals and increments tibbles should probably combined, in a manner similar to

.DefaultIncrementsRelative() %>% tidy()
# A tibble: 2 × 3
    min   max increment
  <dbl> <dbl>     <dbl>
1     0    20      1   
2    20   Inf      0.33

If done, knit_print.IncrementsRelativeParts will need to be modified. This will be straightforward.

@Puzzled-Face Puzzled-Face added enhancement New feature or request good first issue Good for newcomers low priority labels Feb 6, 2024
@Puzzled-Face
Copy link
Collaborator Author

Puzzled-Face commented Feb 6, 2024

.. and similarly for IncrementsRelativeDLTCurrent /knit_print.IncrementsRelativeDLTCurrent and IncrementsRelativeDLT /knit_print.IncrementsRelativeDLT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
Status: To do
Development

No branches or pull requests

1 participant