You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation for the ProbitLogNormal class reads, in part,
This model is also used in the DualEndpoint classes...
which is not strictly true, because DualEndpoint supports both ProbitNormal [a class which does not exist] and ProbitLogNormal models through its use_log_dose slot. ProbitLogNormal has no such flag, so always uses log(x/x*) as a covariate in its model.
Suggestions
Amend the documentation for ProbitLogNormal to clarify that DualEndpoint's model is an extension of ProbitLogNormal.
[Optional] Create a ProbitNormal class to implement the missing model
Creation of the ProbitNormal class (and associated methods) should be straightforward, and would help with the implementation of knit_print methods for model classes. (See #796.) However, note that the name suggested here contradicts the nomenclature used in LogisticLogNormal and LogisticNormal, where the presence or absence of Log defines the prior, not the covariate.
The text was updated successfully, but these errors were encountered:
The documentation for the
ProbitLogNormal
class reads, in part,which is not strictly true, because
DualEndpoint
supports bothProbitNormal
[a class which does not exist] andProbitLogNormal
models through itsuse_log_dose
slot.ProbitLogNormal
has no such flag, so always useslog(x/x*)
as a covariate in its model.Suggestions
ProbitLogNormal
to clarify thatDualEndpoint
's model is an extension ofProbitLogNormal
.ProbitNormal
class to implement the missing modelCreation of the
ProbitNormal
class (and associated methods) should be straightforward, and would help with the implementation ofknit_print
methods for model classes. (See #796.) However, note that the name suggested here contradicts the nomenclature used inLogisticLogNormal
andLogisticNormal
, where the presence or absence ofLog
defines the prior, not the covariate.The text was updated successfully, but these errors were encountered: