prtereachable: fix problem with nl-route #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when its in a non-standard path. observed trying to build main using spack on a system where nl-route rpms aren't installed. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
bwbarrett
approved these changes
Mar 29, 2022
|
@hppritcha while looking at making the same fix in Open MPI, I noticed that this fix was incomplete. You only fixed the issue for when the component is built in libprte. If built as a DSO, the same failure will happen. You need to add the same flags a couple lines up on the other LDFLAGS line. |
|
@bwbarrett thanks for catching this |
hppritcha
added a commit
to hppritcha/prrte
that referenced
this pull request
Mar 30, 2022
oops missed a place to add in nl3 LDFLAGS in the Makefile.am related to openpmix#1315 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
rhc54
pushed a commit
that referenced
this pull request
Mar 31, 2022
oops missed a place to add in nl3 LDFLAGS in the Makefile.am related to #1315 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
rhc54
pushed a commit
to rhc54/prrte
that referenced
this pull request
Apr 21, 2022
oops missed a place to add in nl3 LDFLAGS in the Makefile.am related to openpmix#1315 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit cd4bd73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when its in a non-standard path.
observed trying to build main using spack on a system
where nl-route rpms aren't installed.
Signed-off-by: Howard Pritchard howardp@lanl.gov