Revise show_help to use PMIx IOF #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
force-pushed
the
topic/shlp
branch
2 times, most recently
from
1695035
to
91b3b7a
Compare
When a daemon or the controller emits a "show_help" message, we want it to go to any attached tools that request the STDDIAG channel. In addition, we want it to output to stderr if the user has requested that we do so. In the case of output to the local screen, ensure it only comes once. While we are at it, fix the "unable to launch daemons" message so it includes the case of unresolved nodenames. Signed-off-by: Ralph Castain <rhc@pmix.org>
|
I can confirm this fixes the issue with ompi displaying duplicate help messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a daemon or the controller emits a "show_help" message,
we want it to go to any attached tools that request the
STDDIAG channel. In addition, we want it to output to stderr
if the user has requested that we do so. In the case of output
to the local screen, ensure it only comes once.
While we are at it, fix the "unable to launch daemons" message
so it includes the case of unresolved nodenames.
Refs #1316
Signed-off-by: Ralph Castain rhc@pmix.org