Multiple commits #1672
Merged
Multiple commits #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are mapping to a non-object (i.e., node or slot) and the binding target was not specified, then set the default binding (if supported) to cpu for nprocs <= 2 and to NUMA for nprocs > 2. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit ec471d9)
Deal with mapping by something other than objects to detect cross-package binding. Provide a better error message when we encounter that situation. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 081890a)
Add a couple of missing directives to the output category sanity checker. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit c561a60)
* Don't accidentally remove source files in make clean * Silence compiler warnings Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov> (cherry picked from commit 5d030c9)
Co-authored-by: Ralph Castain <rhc@pmix.org> Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov> (cherry picked from commit 4f652de)
Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov> (cherry picked from commit 83ddaf9)
* Use exit macros in example dmodex * correct exit status in error paths Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov> (cherry picked from commit 2b91998)
Now that hwloc is providing better definition of "allowed" cpus, we no longer want/need to be doing an explicit read of the local affinity. This was incorrectly being applied to all daemons because we assumed that any externally applied binding (e.g., cgroup) would apply to all locations - mpirun as well as compute nodes. Sometimes isn't true, so just avoid the complications. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 5712e2e)
Crossport of open-mpi/ompi#11395 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 8bb7fa1)
No longer required Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 10496e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct default binding for map-by node/slot
If we are mapping to a non-object (i.e., node or slot)
and the binding target was not specified, then set the
default binding (if supported) to cpu for nprocs <= 2
and to NUMA for nprocs > 2.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ec471d9)
Provide better error message for cross-package binding
Deal with mapping by something other than objects to detect
cross-package binding. Provide a better error message when
we encounter that situation.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 081890a)
Add missing command line directives
Add a couple of missing directives to the
output category sanity checker.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit c561a60)
Fix minor issues found in tests.
Signed-off-by: Samuel K. Gutierrez samuel@lanl.gov
(cherry picked from commit 5d030c9)
Silence compiler warning in test/connect.
Co-authored-by: Ralph Castain rhc@pmix.org
Signed-off-by: Samuel K. Gutierrez samuel@lanl.gov
(cherry picked from commit 4f652de)
Silence compiler warnings in examples.
Signed-off-by: Samuel K. Gutierrez samuel@lanl.gov
(cherry picked from commit 83ddaf9)
Use exit macros in example dmodex.
Signed-off-by: Samuel K. Gutierrez samuel@lanl.gov
(cherry picked from commit 2b91998)
Remove antiquated code that can cause problems
Now that hwloc is providing better definition of
"allowed" cpus, we no longer want/need to be
doing an explicit read of the local affinity.
This was incorrectly being applied to all
daemons because we assumed that any externally
applied binding (e.g., cgroup) would apply to
all locations - mpirun as well as compute
nodes. Sometimes isn't true, so just avoid
the complications.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 5712e2e)
Update sphinx requirements
Crossport of open-mpi/ompi#11395
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 8bb7fa1)
@rhc54
Remove the PMIX_SIZE_ESTIMATE support
d5cec23
No longer required
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit rhc54@10496e3)