Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle plugin and packaging #2

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Add bundle plugin and packaging #2

merged 1 commit into from
Mar 8, 2016

Conversation

nicolas-rempulski
Copy link

Add bundle packaging process to declare exported packages in OSGI environment

Add bundle packaging process to declare exported packages in OSGI environment
@vonnieda
Copy link
Member

vonnieda commented Mar 7, 2016

Hi @nicolas-rempulski,

I'm not familiar with the bundle plugin. Can you tell me a little more about what this changes? Will I need to change the release process at all, or does this just add some metadata?

Thanks,
Jason

@nicolas-rempulski
Copy link
Author

Hi @vonnieda,

Bundle packaging is based on BND and is a way for a jar to self-describe itself (mostly packages it provides and packages it requires). It doesn't change the classes bytecode wise, but it add meta informations in the META-INF. In your project, mostly exported packages.

I had to modify your packaging to include it in an OSGI environment (Wisdom Framework) and thought it could be useful if others need this packaging. As it do not modify the bytecode, it is harmless for projects that doesn't use the extra META-INF informations.

I would like to take the opportunity to thank you for this OpenCV packaging. We grabbed the 3.0.0 branch before the merge and we use it actively in our project and his saved us a lot of headaches :)

vonnieda added a commit that referenced this pull request Mar 8, 2016
Add bundle plugin and packaging
@vonnieda vonnieda merged commit e560631 into openpnp:develop Mar 8, 2016
@vonnieda
Copy link
Member

vonnieda commented Mar 8, 2016

Thanks for the explanation and for the pull request @nicolas-rempulski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants