Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

Merge in @OlegKi's JavaScript changes. #36

Closed
meh-uk opened this issue Jan 12, 2015 · 12 comments
Closed

Merge in @OlegKi's JavaScript changes. #36

meh-uk opened this issue Jan 12, 2015 · 12 comments
Milestone

Comments

@meh-uk
Copy link
Contributor

meh-uk commented Jan 12, 2015

No description provided.

@bouks
Copy link
Contributor

bouks commented Jan 12, 2015

What's this about ? :)

@meh-uk
Copy link
Contributor Author

meh-uk commented Jan 12, 2015

Just making sure the issue we have discussed the most as being urgent is actually tracked.

@flack
Copy link
Contributor

flack commented Jan 12, 2015

Yes, having a ticket for this makes it a lot easier to handle (compared to random mails). The JS changes are currently synched up to (but not including) this one:

free-jqgrid/jqGrid@3ab18e9

Next steps:

After, I would propose we wait for @OlegKi's documentation of his changes, because we need to keep our documentation in sync

@bouks
Copy link
Contributor

bouks commented Jan 12, 2015

This one :

free-jqgrid/jqGrid@3ab18e9

was a change i did, it was committed by me here :

da6a917

and here :

10b1cd7

So the Oleg's mentionned commit merge must be avoided.

Considering this one :

free-jqgrid/jqGrid@aeb6192

There is no real conflict as autodetection doesn't care about it.

@meh-uk meh-uk added this to the 1.0 milestone Jan 12, 2015
@meh-uk
Copy link
Contributor Author

meh-uk commented Jan 13, 2015

I'm starting this now, and it's heavy going, practically every commit conflicts, @OlegKi please can you stop making changes to your old branch and start making them from a new fork of this project? It isn't going to be possible for us to merge any more of your changes otherwise.

@meh-uk
Copy link
Contributor Author

meh-uk commented Jan 13, 2015

OK I've done the first ten or so commits and created pull #50. But it took ages to do even that small a number.

@flack
Copy link
Contributor

flack commented Jan 13, 2015

I have done another ten now, next one will be free-jqgrid/jqGrid@1fabe17

@flack
Copy link
Contributor

flack commented Jan 13, 2015

P.S.: We still need to update the documentation for changed defaults & such

@meh-uk
Copy link
Contributor Author

meh-uk commented Jan 13, 2015

See the release notes file I created yesterday, it has the language file changes.

@flack
Copy link
Contributor

flack commented Jan 13, 2015

Yes, I saw. So we need to update the release notes and the options.md page

@bouks
Copy link
Contributor

bouks commented Jan 13, 2015

moving to : #50

@meh-uk
Copy link
Contributor Author

meh-uk commented Jan 14, 2015

Added #57 earlier, and now #60 so all of the JavaScript changes should now be merged.

@meh-uk meh-uk changed the title Merge in @OlegKi's css and JavaScript changes. Merge in @OlegKi's JavaScript changes. Jan 14, 2015
@flack flack closed this as completed Feb 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants