Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

remove templates in grid.base #75

Open
bouks opened this issue Jan 23, 2015 · 2 comments
Open

remove templates in grid.base #75

bouks opened this issue Jan 23, 2015 · 2 comments
Milestone

Comments

@bouks
Copy link
Contributor

bouks commented Jan 23, 2015

I think including templates in grid.base is not a good thing. It makes the program bigger and some people won't use it or create their own templates (what about naming conflicts ?).
We can do separate file for this if we want to offer templates or just let responsability to the user to create templates.

I propose to remove them (they do not exist in jqgrid) included by this commit :

788418f

@flack
Copy link
Contributor

flack commented Jan 23, 2015

Well, naming conflicts shouldn't be a problem. If a user defines e.g. an integer template, it will simply override the default one.

The file size also doesn't bother me very much, since it's only 14 lines uncompressed (but maybe that's only because I don't use jqgrid in high-traffic sites :-)).

In general, I like the idea of making configuration easier, but maybe we could do it a bit smarter. For example, if you set formatter: 'number' on a column, jqgrid could automatically change the default sorttype to "number" as well (and vice versa). The only problem is that this could add even more code..

@meh-uk meh-uk added this to the 1.0 milestone Feb 7, 2015
@meh-uk
Copy link
Contributor

meh-uk commented Mar 4, 2015

Do we need to fix this before release or can it wait?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants