You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
I think including templates in grid.base is not a good thing. It makes the program bigger and some people won't use it or create their own templates (what about naming conflicts ?).
We can do separate file for this if we want to offer templates or just let responsability to the user to create templates.
I propose to remove them (they do not exist in jqgrid) included by this commit :
Well, naming conflicts shouldn't be a problem. If a user defines e.g. an integer template, it will simply override the default one.
The file size also doesn't bother me very much, since it's only 14 lines uncompressed (but maybe that's only because I don't use jqgrid in high-traffic sites :-)).
In general, I like the idea of making configuration easier, but maybe we could do it a bit smarter. For example, if you set formatter: 'number' on a column, jqgrid could automatically change the default sorttype to "number" as well (and vice versa). The only problem is that this could add even more code..
I think including templates in grid.base is not a good thing. It makes the program bigger and some people won't use it or create their own templates (what about naming conflicts ?).
We can do separate file for this if we want to offer templates or just let responsability to the user to create templates.
I propose to remove them (they do not exist in jqgrid) included by this commit :
788418f
The text was updated successfully, but these errors were encountered: