Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TD mission objective punctuation consistent #8356

Merged
merged 1 commit into from Jun 6, 2015

Conversation

clemty
Copy link
Contributor

@clemty clemty commented Jun 1, 2015

some mission objectives end with ".", most don't - this removes the punctuation for consistency

some nod objectives end with an exclamation mark, I kept that even though it is inconsistent through nod missions as well

edit: I addded fullstops to all objectives and replaced exclamation marks in the process

@Unit158
Copy link
Contributor

Unit158 commented Jun 1, 2015

How about we end them all with periods instead of leaving some with exclamation points?

EDIT: I'm not really opposed to having it like this, so 👍 either way, I would just prefer periods.

@clemty
Copy link
Contributor Author

clemty commented Jun 1, 2015

I assumed that the default is "no punctuation" since that was the case in the majority of objectives, but a quick online search shows that punctuation like in sentences is apparently good style so you're right and there should be punctuation:

http://www.onlinegrammar.com.au/punctuation-in-lists/
http://www.getitwriteonline.com/archive/101406VerticalLists.htm

@abcdefg30
Copy link
Member

Somehow I'd prefer fullstops, but above sounds reasonable, so 👍 / ✅

@obrakmann
Copy link
Contributor

I'm in the "proper punctuation at all times, please"-camp.

@pchote
Copy link
Member

pchote commented Jun 2, 2015

Everyone seems to agree that punctuation is required.

@clemty clemty changed the title removes fullstop from mission objectives make TD mission objective punctuation consistent Jun 4, 2015
@obrakmann
Copy link
Contributor

You missed one in gdi03, but that's the objective for the AI player which is never shown anywhere, so 👍

obrakmann added a commit that referenced this pull request Jun 6, 2015
make TD mission objective punctuation consistent
@obrakmann obrakmann merged commit 929df0a into OpenRA:bleed Jun 6, 2015
@obrakmann
Copy link
Contributor

Thanks!

Changelog

@clemty clemty deleted the upstream/missionobj branch June 19, 2015 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants