POSIX compliance #8405
POSIX compliance #8405
Conversation
Also works on FreeBSD I didn't fix the MakeFile, though
|
👍 Still works fine for me under openSUSE Linux. ✅ |
|
@Mailaender That is the point of POSIX-compliance 😝 work on Linux, BSDs, OSX and whatnot... |
|
the travis log shows this: |
| locations=(/lib /lib64 /usr/lib /usr/lib64 /usr/lib/i386-linux-gnu /usr/lib/x86_64-linux-gnu /usr/local/lib /opt/lib) | ||
| sonames=(liblua.so.5.1.5 liblua5.1.so.5.1 liblua5.1.so.0 liblua.so.5.1 liblua-5.1.so liblua5.1.so) | ||
| os="$(uname -s)" | ||
| if [ "$os" == 'Linux' ] || [ "$os" == 'FreeBSD' ]; then |
There was a problem hiding this comment.
This line seems to fail under Ubuntu.
There was a problem hiding this comment.
I can't begin to understand why 😮
There was a problem hiding this comment.
Just remove it. We don't really need it anymore. The real check moved to the https://github.com/OpenRA/OpenRA/blob/bleed/Makefile#L78
Replaced it with =
| locations=(/lib /lib64 /usr/lib /usr/lib64 /usr/lib/i386-linux-gnu /usr/lib/x86_64-linux-gnu /usr/local/lib /opt/lib) | ||
| sonames=(liblua.so.5.1.5 liblua5.1.so.5.1 liblua5.1.so.0 liblua.so.5.1 liblua-5.1.so liblua5.1.so) | ||
| os="$(uname -s)" | ||
| if [ "$os" = 'Linux' ] || [ "$os" = 'FreeBSD' ]; then |
There was a problem hiding this comment.
Turns out your latest change completely breaks it for Ubuntu. Notice the missing line "Detected Lua 5.1 library" at https://travis-ci.org/OpenRA/OpenRA/builds/65695051
There was a problem hiding this comment.
I don't have an Ubuntu at hand. I'd appreciate it if someone had one and could actually post only the result of sh ./thirdparty/configure-linux-native-deps.sh after adding set -x right under the shebang.
It works on Archlinux and FreeBSD.
There was a problem hiding this comment.
@Mailaender: the missing "Detected Lua" line is ok, lua isn't installed in the travis vm. (Which is ok, because the generated Eluant.dll.config isn't used for the debian package.)
|
👍 works fine here too |
|
Thanks! |
I want to run a dedicated on FreeBSD, hence the 3 issues and this PR