New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to prevent crashes when signal scripts use a bad draw state #696
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Aug 18, 2022
- Pull request #537 at 939b2b2: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
Sharpe49
approved these changes
Aug 18, 2022
twpol
pushed a commit
that referenced
this pull request
Aug 18, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
twpol
pushed a commit
that referenced
this pull request
Aug 19, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 4538fe6: Upgrade libraries to netstandard 2.0 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
twpol
pushed a commit
that referenced
this pull request
Aug 19, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
twpol
pushed a commit
that referenced
this pull request
Aug 19, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at dda1a8a: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at b23557a: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2022
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 17a6be4: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #693 at 8162969: French locales - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
Csantucci
added a commit
to Csantucci/openrails
that referenced
this pull request
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix in case draw state index does not correspond to a valid draw state