Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sander ignores maximum sanding speed #840

Merged
merged 1 commit into from Jun 21, 2023
Merged

Sander ignores maximum sanding speed #840

merged 1 commit into from Jun 21, 2023
+20 −100

Conversation

SteelFill
Copy link
Contributor

@SteelFill SteelFill commented Jun 7, 2023 •
edited by twpol

Baby's first pull request. Probably something weird looking or wrong in here (yes there are 7 commits, 6 of those were me trying to un-break something), just let me know if that's the case.

Fix for the issue noted here http://www.elvastower.com/forums/index.php?/topic/37178-ineffective-train-brakes/page__view__findpost__p__297807 and here https://bugs.launchpad.net/or/+bug/2023083

  • when above the speed defined by Sanding(), use of sand no longer increases adhesion
  • sand is no longer consumed if sanding is blocked
  • prevented sanding from reducing adhesion, which was possible in some cases
  • general clean-up and simplification of sand friction code

Even when sanding is blocked, sanding sounds and cab sand indicator lights will still function. It's not realistic, but fixing that would require a rework of the way sand events are handled and I'm not interested in that right now.

@cesarBLG cesarBLG added bug Something isn't working for-unstable Special label to include a pull request in the Unstable Version labels Jun 7, 2023
twpol pushed a commit that referenced this pull request Jun 7, 2023
@openrails-bot
Automatic merge of T1.5.1-413-g1daa6a7c6 and 21 pull requests
9ec450a 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ceeaba7: Electric locomotive hot start
- Pull request #831 at c8927a4: preliminary version switchpanel on tablet
- Pull request #834 at 7a98eca: Replaces email service with FormSpark
- Pull request #835 at c3d05c4: Correct Brake Shoe Force Calculation
- Pull request #836 at 62e6d02: Adds policy on crashes and derailments
- Pull request #837 at 0497316: copies website policies to repo
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
@cesarBLG
Copy link
Contributor

cesarBLG commented Jun 7, 2023

Thanks for the fix! The code is now much simpler than it was. I tagged the PR as "for-unstable" so that it appears in next unstable release, so users can test it.

twpol pushed a commit that referenced this pull request Jun 8, 2023
@openrails-bot
Automatic merge of T1.5.1-413-g1daa6a7c6 and 21 pull requests
bb4be1d 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ceeaba7: Electric locomotive hot start
- Pull request #831 at c8927a4: preliminary version switchpanel on tablet
- Pull request #834 at 7a98eca: Replaces email service with FormSpark
- Pull request #835 at 756716b: Correct Brake Shoe Force Calculation
- Pull request #836 at 62e6d02: Adds policy on crashes and derailments
- Pull request #837 at 0497316: copies website policies to repo
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 8, 2023
@openrails-bot
Automatic merge of T1.5.1-413-g1daa6a7c6 and 21 pull requests
098d9d6 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ceeaba7: Electric locomotive hot start
- Pull request #831 at c8927a4: preliminary version switchpanel on tablet
- Pull request #834 at 7a98eca: Replaces email service with FormSpark
- Pull request #835 at 1b6ca35: Correct Brake Shoe Force Calculation
- Pull request #836 at 62e6d02: Adds policy on crashes and derailments
- Pull request #837 at 0497316: copies website policies to repo
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 9, 2023
@openrails-bot
Automatic merge of T1.5.1-413-g1daa6a7c6 and 20 pull requests
1b47f54 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ceeaba7: Electric locomotive hot start
- Pull request #834 at 7a98eca: Replaces email service with FormSpark
- Pull request #835 at 1b6ca35: Correct Brake Shoe Force Calculation
- Pull request #836 at 62e6d02: Adds policy on crashes and derailments
- Pull request #837 at 0497316: copies website policies to repo
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 10, 2023
@openrails-bot
Automatic merge of T1.5.1-427-g8a33d6c8b and 13 pull requests
26c67dd 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 45a411f: Electric locomotive hot start
- Pull request #835 at 1b6ca35: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 10, 2023
@openrails-bot
Automatic merge of T1.5.1-427-g8a33d6c8b and 13 pull requests
63078e4 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 45a411f: Electric locomotive hot start
- Pull request #835 at fa510b0: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 10, 2023
@openrails-bot
Automatic merge of T1.5.1-427-g8a33d6c8b and 13 pull requests
5a9bc74 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 45a411f: Electric locomotive hot start
- Pull request #835 at 037dbdf: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 11, 2023
@openrails-bot
Automatic merge of T1.5.1-427-g8a33d6c8b and 13 pull requests
92973c1 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 45a411f: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 11, 2023
@openrails-bot
Automatic merge of T1.5.1-427-g8a33d6c8b and 13 pull requests
ff5c838 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #818 at 23f3488: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 12, 2023
@openrails-bot
Automatic merge of T1.5.1-437-g40a311d87 and 11 pull requests
aeae376 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 12, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 10 pull requests
719b80b 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
twpol pushed a commit that referenced this pull request Jun 12, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 11 pull requests
633f1b9 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #841 at 65eeaa7: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
twpol pushed a commit that referenced this pull request Jun 13, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 12 pull requests
27d3a69 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #841 at 65eeaa7: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 13, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 11 pull requests
b3c334e 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at ce2726a: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 13, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 11 pull requests
a4d1f3a 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 19ee760: Electric locomotive hot start
- Pull request #835 at 4c9375e: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 14, 2023
@openrails-bot
Automatic merge of T1.5.1-440-g0914a53e4 and 11 pull requests
7790927 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 19ee760: Electric locomotive hot start
- Pull request #835 at e632edb: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 14, 2023
@openrails-bot
Automatic merge of T1.5.1-442-gbaefb6b08 and 10 pull requests
e08d9f8 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at 19ee760: Electric locomotive hot start
- Pull request #835 at e632edb: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 14, 2023
@openrails-bot
Automatic merge of T1.5.1-442-gbaefb6b08 and 10 pull requests
d8d14ab 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #835 at e632edb: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at a4a5592: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 15, 2023
@openrails-bot
Automatic merge of T1.5.1-442-gbaefb6b08 and 10 pull requests
309d596 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #835 at e632edb: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at 6abb30d: Set up ability for steam locomotives to have multiple engines
twpol pushed a commit that referenced this pull request Jun 17, 2023
@openrails-bot
Automatic merge of T1.5.1-442-gbaefb6b08 and 11 pull requests
ab34e0f 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #835 at e632edb: Correct Brake Shoe Force Calculation
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at 6abb30d: Set up ability for steam locomotives to have multiple engines
- Pull request #843 at eb7efa3: Fix for https://bugs.launchpad.net/or/+bug/2024295  Freight weight only added for first wagon
twpol pushed a commit that referenced this pull request Jun 18, 2023
@openrails-bot
Automatic merge of T1.5.1-470-ga80e86872 and 10 pull requests
10c98f7 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at 6abb30d: Set up ability for steam locomotives to have multiple engines
- Pull request #843 at eb7efa3: Fix for https://bugs.launchpad.net/or/+bug/2024295  Freight weight only added for first wagon
twpol pushed a commit that referenced this pull request Jun 18, 2023
@openrails-bot
Automatic merge of T1.5.1-470-ga80e86872 and 10 pull requests
4352b46 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at 6abb30d: Set up ability for steam locomotives to have multiple engines
- Pull request #843 at eb7efa3: Fix for https://bugs.launchpad.net/or/+bug/2024295  Freight weight only added for first wagon
twpol pushed a commit that referenced this pull request Jun 19, 2023
@openrails-bot
Automatic merge of T1.5.1-472-g8e1445425 and 9 pull requests
de37924 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at e30b900: Electric locomotive hot start
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #840 at daca020: Bug fix for sanding max speed not working
- Pull request #842 at 9c2724d: Set up ability for steam locomotives to have multiple engines
cesarBLG
cesarBLG approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@cesarBLG cesarBLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been in the unstable release for a while without any complains. It is OK to me.
I did some cleanup to revert undesired commits.

@SteelFill
Copy link
Contributor Author

Thanks for figuring out how to clean up those commits, that was really driving me crazy and I didn't come across any non-intimidating ways to get it to ignore the commits I reverted.

@cesarBLG cesarBLG merged commit 7f7dd99 into openrails:master Jun 21, 2023
3 checks passed
@SteelFill SteelFill deleted the sanding-fix branch June 21, 2023 20:02
@twpol twpol changed the title Bug fix for sanding max speed not working Sander ignores maximum sanding speed Jul 1, 2023
@SteelFill SteelFill mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarBLG cesarBLG cesarBLG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working for-unstable Special label to include a pull request in the Unstable Version
Milestone
No milestone
2 participants
@SteelFill @cesarBLG