Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify RailDriver code implementations #757

Merged
merged 13 commits into from Sep 19, 2023
Merged

Unify RailDriver code implementations #757

merged 13 commits into from Sep 19, 2023

Conversation

cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG commented Dec 16, 2022 •
edited

@cesarBLG cesarBLG added help wanted Extra attention is needed refactoring Changes with minimal user-visible effects not-for-unstable Special label to exclude a pull request from the Unstable Version labels Dec 16, 2022
@cesarBLG cesarBLG mentioned this pull request Dec 16, 2022
Closed
@cesarBLG cesarBLG removed the help wanted Extra attention is needed label Dec 26, 2022
Csantucci added a commit to Csantucci/openrails that referenced this pull request Jan 2, 2023
@Csantucci
Merge PR openrails#757 - Unify Raildriver code implementation, by ces…
c5bad00 
…arBLG
Csantucci added a commit to Csantucci/openrails that referenced this pull request Jan 2, 2023
@Csantucci
Merge PR openrails#757 - Unify Raildriver code implementation, by ces…
585e248 
…arBLG
@Csantucci
Copy link
Contributor

Csantucci commented Feb 14, 2023 •
edited

To solve this http://www.elvastower.com/forums/index.php?/topic/24040-3d-cabs/page__view__findpost__p__294295
here is a suggested fix:
diff --git a/Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs b/Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs
index 59159c92f..c81f35a0c 100644
--- a/Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs
+++ b/Source/RunActivity/Viewer3D/RollingStock/MSTSLocomotiveViewer.cs
@@ -246,7 +246,7 @@ public override void HandleUserInput(ElapsedTime elapsedTime)
foreach (var kvp in external.CabControls)
{

  •                if (_CabRenderer == null) break;

  •                if (_CabRenderer == null && !_has3DCabRenderer) break;
               if (!kvp.Value.Changed) continue;
               float val = kvp.Value.Value;
               switch (kvp.Key.Item1.Type)

--

@cesarBLG
Copy link
Contributor Author

Thanks, Carlo. I uploaded the fix at #751 which is the first part of this PR, where this bug was introduced. I had to modify your fix because otherwise you would get a crash when using the web server.

@cesarBLG cesarBLG marked this pull request as ready for review February 22, 2023 07:11
@cesarBLG cesarBLG mentioned this pull request Feb 22, 2023
Merged
@cesarBLG cesarBLG removed the not-for-unstable Special label to exclude a pull request from the Unstable Version label May 5, 2023
@cesarBLG cesarBLG added the not-for-unstable Special label to exclude a pull request from the Unstable Version label May 7, 2023
@cesarBLG cesarBLG removed the not-for-unstable Special label to exclude a pull request from the Unstable Version label May 8, 2023
twpol pushed a commit that referenced this pull request May 8, 2023
@openrails-bot
Automatic merge of T1.5.1-411-g51d4cd969 and 14 pull requests
b2000a2 
- Pull request #570 at de7a14f: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 2388225: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at ff454eb: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 745d101: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at b9350ff: Electric locomotive hot start
twpol pushed a commit that referenced this pull request May 8, 2023
@openrails-bot
Automatic merge of T1.5.1-411-g51d4cd969 and 14 pull requests
943314f 
- Pull request #570 at de7a14f: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 2388225: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 745d101: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at b9350ff: Electric locomotive hot start
twpol pushed a commit that referenced this pull request May 8, 2023
@openrails-bot
Automatic merge of T1.5.1-411-g51d4cd969 and 15 pull requests
6f08535 
- Pull request #570 at de7a14f: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 2388225: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #802 at 4d198e4: Added support for activity location events to the TrackViewer
- Pull request #803 at 7157e08: Various adjustments to steam adhesion
- Pull request #813 at 7fdad38: Refactored garbage generators
- Pull request #815 at a5cc165: chore: Add GitHub automatic release notes configuration
- Pull request #818 at 745d101: Allow independent drive axles for locomotives
- Pull request #821 at e0fa5a8: Adds suppression of safety valves
- Pull request #823 at 5e1c03b: Select track sound volume percent retained in .eng and .wag files
- Pull request #824 at f16ebed: Update Readme.md
- Pull request #825 at 29ed427: 2D Cabview controls for side viewpoints https://blueprints.launchpad.net/or/+spec/2dcabview-controls-for-side-views
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #830 at b9350ff: Electric locomotive hot start
- Pull request #831 at 6a319a8: preliminary version switchpanel on tablet
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-550-ge91bba953 and 14 pull requests
4b97ee5 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 13 pull requests
89c91ae 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 26, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 13 pull requests
a300e37 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 3097086: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 26, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
efee2ae 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 3097086: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 27, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
b812b4d 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 9d8513a: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 27, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
e8505cb 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 9d8513a: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 28, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
44c05de 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 30, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
b2046ed 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 30, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
1335eec 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 31, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 15 pull requests
1855c90 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
- Pull request #868 at 1b42d4c: Bug  fix for Exhaust of non-lead diesels is not correct https://bugs.launchpad.net/or/+bug/2033621
twpol pushed a commit that referenced this pull request Sep 5, 2023
@openrails-bot
Automatic merge of T1.5.1-561-g5e31b2390 and 13 pull requests
31ca054 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Sep 5, 2023
@openrails-bot
Automatic merge of T1.5.1-561-g5e31b2390 and 14 pull requests
cb43104 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 6, 2023
@openrails-bot
Automatic merge of T1.5.1-567-gefb91a402 and 13 pull requests
7124409 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 7, 2023
@openrails-bot
Automatic merge of T1.5.1-569-g8f17be306 and 12 pull requests
ef785cc 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 9, 2023
@openrails-bot
Automatic merge of T1.5.1-569-g8f17be306 and 13 pull requests
a339044 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
twpol pushed a commit that referenced this pull request Sep 10, 2023
@openrails-bot
Automatic merge of T1.5.1-569-g8f17be306 and 14 pull requests
cbe75e1 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
- Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
twpol pushed a commit that referenced this pull request Sep 10, 2023
@openrails-bot
Automatic merge of T1.5.1-569-g8f17be306 and 14 pull requests
f517a67 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
- Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
twpol pushed a commit that referenced this pull request Sep 14, 2023
@openrails-bot
Automatic merge of T1.5.1-573-g9a8e6af15 and 13 pull requests
3b7bd44 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
twpol pushed a commit that referenced this pull request Sep 14, 2023
@openrails-bot
Automatic merge of T1.5.1-573-g9a8e6af15 and 14 pull requests
dfaedce 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 14, 2023
@openrails-bot
Automatic merge of T1.5.1-573-g9a8e6af15 and 14 pull requests
b5c21bb 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at 516825f: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
@openrails-bot
Automatic merge of T1.5.1-585-g2be1faa5d and 12 pull requests
d6fa5da 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
@openrails-bot
Automatic merge of T1.5.1-585-g2be1faa5d and 12 pull requests
462902d 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at fc94364: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
@openrails-bot
Automatic merge of T1.5.1-585-g2be1faa5d and 12 pull requests
1623f62 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 82d3be2: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
@openrails-bot
Automatic merge of T1.5.1-585-g2be1faa5d and 12 pull requests
6971c40 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 16, 2023
@openrails-bot
Automatic merge of T1.5.1-594-g5f7e60929 and 11 pull requests
abb56c8 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 16, 2023
@openrails-bot
Automatic merge of T1.5.1-599-g782e611d5 and 9 pull requests
67b1bf3 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 17, 2023
@openrails-bot
Automatic merge of T1.5.1-599-g782e611d5 and 10 pull requests
82b7594 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
- Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs
Csantucci
Csantucci approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Csantucci Csantucci left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now long time here and no one has complained; functional test was OK, and at a short glance the code is OK, so I approve it. Thanks for the valuable and significant effort.

@cesarBLG
Copy link
Contributor Author

Thanks for review, Carlo!

@cesarBLG cesarBLG merged commit 370920e into openrails:master Sep 19, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Csantucci Csantucci Csantucci approved these changes

Assignees
No one assigned
Labels
refactoring Changes with minimal user-visible effects
Milestone
No milestone
2 participants
@cesarBLG @Csantucci