New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alternate Syntax for Confusing Tokens #856
Merged
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarBLG
added
the
for-unstable
Special label to include a pull request in the Unstable Version
label
Jul 30, 2023
twpol
pushed a commit
that referenced
this pull request
Jul 31, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at 8357922: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens
twpol
pushed a commit
that referenced
this pull request
Aug 1, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at 52a513d: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens
twpol
pushed a commit
that referenced
this pull request
Aug 1, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at 36736ce: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens
twpol
pushed a commit
that referenced
this pull request
Aug 1, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at 36736ce: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 7931a52: Adding Air Flow Meters
twpol
pushed a commit
that referenced
this pull request
Aug 1, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 7931a52: Adding Air Flow Meters
twpol
pushed a commit
that referenced
this pull request
Aug 2, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 7931a52: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems
twpol
pushed a commit
that referenced
this pull request
Aug 3, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at ce66076: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 22312be: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems
twpol
pushed a commit
that referenced
this pull request
Aug 3, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 22312be: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems
twpol
pushed a commit
that referenced
this pull request
Aug 5, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems
twpol
pushed a commit
that referenced
this pull request
Aug 6, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at d6d0c82: Steam adhesion bug#1
twpol
pushed a commit
that referenced
this pull request
Aug 7, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at d6d0c82: Steam adhesion bug#1 - Pull request #860 at 91f0a35: Changes in the Car Operations Menu for the lines with brake information
twpol
pushed a commit
that referenced
this pull request
Aug 8, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at d6d0c82: Steam adhesion bug#1 - Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
twpol
pushed a commit
that referenced
this pull request
Aug 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
twpol
pushed a commit
that referenced
this pull request
Aug 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at d652a06: Curve friction#1
twpol
pushed a commit
that referenced
this pull request
Aug 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at d2e63f1: Curve friction#1
twpol
pushed a commit
that referenced
this pull request
Aug 11, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1
twpol
pushed a commit
that referenced
this pull request
Aug 13, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 82ab6ce: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1
twpol
pushed a commit
that referenced
this pull request
Aug 13, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at 82ab6ce: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem
cesarBLG
reviewed
Aug 15, 2023
twpol
pushed a commit
that referenced
this pull request
Aug 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem
Was more likely to cause confusion than resolve confusion
twpol
pushed a commit
that referenced
this pull request
Aug 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 076c77a: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem
cesarBLG
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me
twpol
pushed a commit
that referenced
this pull request
Aug 17, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at fe901d3: Alternate preset 3D cabviewpoints, see TrelloBox https://trello.com/c…
twpol
pushed a commit
that referenced
this pull request
Aug 19, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
twpol
pushed a commit
that referenced
this pull request
Aug 19, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at bc03dd8: Dispatcher window improvements
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at 079300b: Dispatcher window improvements
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at 8da038f: Dispatcher window improvements
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at 8918de1: Dispatcher window improvements
twpol
pushed a commit
that referenced
this pull request
Aug 20, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at cb3f1c0: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at 7d62bb2: Dispatcher window improvements
twpol
pushed a commit
that referenced
this pull request
Aug 21, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #831 at 61bbf43: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at a9760ec: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens - Pull request #857 at 9afc8c3: Adding Air Flow Meters - Pull request #858 at bbaeeba: Fix wheel animation problems - Pull request #859 at 30d7b53: Steam adhesion bug#1 - Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information - Pull request #861 at 2c39260: Curve friction#1 - Pull request #862 at 489f261: Fix engine leak problem - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #865 at 7d62bb2: Dispatcher window improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
for-unstable
Special label to include a pull request in the Unstable Version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tokens have syntax that doesn't conform to user expectations, resulting in some users, even payware developers, to either use syntax that doesn't work or to just avoid some features as the inconsistent syntax is too confusing to use. This PR adds alternate syntax to allow the confused tokens to be implemented in ways users expect and understand.
Specifically:
ORTSAirBrakeMainResVolume
as an alternate token forAirBrakesMainResVolume
. Some community members, and even payware developer TrainSimulations, were misled into thinking this token existed when it did not, resulting in locomotives with smaller (default-sized) main reservoirs than intended. As this 'ORTS...' syntax has been used so much, it makes more sense to add it officially than to attempt to change the minds of those who have used it for years.orts ( )
block to also be parsed if placed outside of an orts ( ) block. A very small number of tokens needed to be in anengine(orts(
section, which is ultimately redundant as the token names already have 'orts' in them, and is also confusing because it is inconsistent with the multitude of tokens which do not require an orts ( ) block. Users have shown confusion with the whole orts ( ) block thing, and some have gotten the impression that the orts ( ) block isn't necessary (even though it is), so allowing this alternate should vibe better with people.ortsadhesion ( )
block. While this is more sensible than the orts ( ) block, there's 2ORTSAdhesion( ORTS... (
tokens, which is still redundant, adding unneeded complexity and room for user error.Parsing of the original syntax still remains to retain support for users who were able to decipher the correct formatting. Similarly, I'm not intending on changing the documentation for these tokens as the changes here are only intended to be a fallback to account for user error and their use does not need to be encouraged.
Discussion on this issue came up here on ElvasTower, in response to the tweaks to sander behavior included in PR #840, and the subsequent confusion that
ORTSSanderSpeedEffectUpTo
wouldn't work unless inside anengine(orts(
section.